Re: RFS: Jampal (2nd try)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Peter,
On 24.05.2011 02:29, Peter Bennett wrote:
> This is my second attempt. I have fixed errors that were pointed out to
> me last time.
glad to see you fixed most of the problems I addressed last time. Thank
you very much.
This time I have some minor, mostly cosmetic issues only but please note
I didn't extensively review your package. I was just looking how you are
doing. Here we go:
* Your standards version is still outdated. Please push to 3.9.2 after
verifying eventual changes [1]
* Please remove the VCS links in your control file if you don't use it.
Even better it would be, if you would use a VCS for Debian related
packaging though :)
* Another thing I mentioned last time is to eventually push debhelper
compatibility level to version 8 (in debian/compat and debian/control).
This is the recommended version as of today.
* Benoît already mentioned the concerns about OpenOffice I addressed
last time as well [2]. You can certainly recommend it if you believe
this is the way to go, see [3] for the precise meaning of package
relationships. However you still need to exchange OpenOffice by
LibreOffice. Its the latter which is in Debian now.
* The long description of tagbkup (glad you made a dedicated package for
it!) contains something like "(use the -cm option, see below)" which was
probably extracted from a manual or so. Please rework the description
since neither the switch should be explained in the description field
not does "below" exist at all.
[1] http://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt
[2] http://lists.debian.org/debian-mentors/2011/05/msg00307.html
[3]
http://www.debian.org/doc/debian-policy/ch-relationships.html#s-binarydeps
- --
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJOEjjjAAoJEMcrUe6dgPNtUlMQAL1w2dqJX3AuGTjGdiN9D5D/
bf9AtaudC3VVj+CiQRtMaArb6IwM8WgqSoVM3mAuNOsRETBIhg6MZAHnIiv+T1AX
E4HqjJmzz1XVTG1HQIFmvLBwkse4aIJuZYJHbRv8y+BwvTmVLbKmlfGIobTZ9at/
5OSnA1AkMpMm5OFS8y0SfJUiWzEOJd6ik5w+dyXK9KYr03cF5EPuFPQr7yISXHPS
+NElnDHazTGeeLqbqXZ8N8ziTWu8iCHUqv97W7ioB7cQhWkq0m0BNR6uARU9n33u
6n471gBcv9UHlZM7jRskAIUwIPtC93wGaSMw7OXBz/tj9TcV3ouWA2iyaGnFJSkk
+v3xOxxMnjQhpyVX6r8KqommrqtEbrl97++gAfl7Wv9h4diVHdTcKTRLju7K2BeG
sHqy/hatiWbAQ6/n1Fw2uN4xBKdBSGpHGF4TshLbNPHERWnWugee4XxB+xEb03D5
ncRLUsfYSd5Dv0FiRdYFhpTui+0xZrluGuviz1WtPSeLCFlb4nvTyc2mCH7BxpRk
ZH+whEbBZEevGax2NWQIYdBKhgbjT5AfyrUBqVBt/+OXoedkVmOadFS3nGPYYWHT
ylA1a2uTFuNJVs+4Syqilz/z9B92MdGhUBZCkp3hnzgMM4fiPOGugXs6gw7+SsE/
1g+1/llE9GrjVa5dTPAy
=Szwr
-----END PGP SIGNATURE-----
Reply to: