Re: RFS: minidlna

[Benoît Knecht <benoit.knecht@fsfe.org>]

Hi Michael,

Sorry for the delay, but I've been awfully busy over the week end.

Michael Tautschnig wrote:
> > It seems like a clever thing to do in {pre,post}inst: there's no need to
> > create a default minidlna user:group if something else is already set in
> > the default file; I'm just unsure if it should create the user:group
> > found in the default file if they do not exist already (if they do not
> > exist, they were most likely removed by the user manually, and
> > re-creating them silently as system users seems like a bad idea).
> > 
> > And in postrm, I would not remove any user:group except
> > minidlna:minidlna, which was normally created by preinst.
> > 
> > Is this what you had in mind? I'll implement those changes, and upload a
> > new version soon.
> 
> Well, actually I would have been ok with the naive use&create/remove whatever
> the user specified in defaults; but you're absolutely right, you could and
> should be more careful here. I think it would be fine to abort in case user and
> group are not equal to minidlna and do not exist.

I just uploaded a new version (1.0.18-3) [1] that addresses all the
issues you've pointed out to me (except the missing license headers,
I'll ask upstream about that).

I hope I didn't miss anything, but please let me know if there are any
problems left.

Cheers,

-- 
Benoît Knecht

---
[1] http://mentors.debian.net/debian/pool/main/m/minidlna