Re: RFS: abiword (updated package)
The license of plugins/opendocument/common/xp/crypto/blowfish/ looks
like it is the original BSD license with obnoxious advertising clause,
which is incompatible with the GNU GPL IIRC. This is the blocker for
uploading it. Please talk to upstream about that.
http://www.gnu.org/licenses/license-list.html#OriginalBSD
In addition it is an embedded code copy of part of OpenSSL, the
security team does not like those.
Are there any changes that need to be cherry-picked for squeeze? The
memory leak fixes might be one.
The version of libloudmouth required has been bumped, please add that
to debian/control.
Some of the copyright holder info has changed, best update debian/copyright.
No need for the extra .0 in Standards-Version, 3.9.1.X versions are compatible.
Please work with the Xubuntu maintainers to reduce the delta with
Debian. Maybe you will get some co-maintainers out of it.
Since abiword gets a lot of bug reports in Debian and Ubuntu, you
might want to organise a bug triage session. I'd suggest involving the
Xubuntu maintainers, Abiword upstream, and Debian GNOME/Xfce folks.
You could also announce it on debian-devel and Planet Debian. Maybe
you will get some co-maintainers out of it.
You may want to move the git repo to collab-maint in case the above
two things get you some co-maintainers.
topgit seems to introduce some spurious changes to the patches that
show up when I do debdiff to review the changes. Any way you can turn
that off?
If you haven't already, please attempt to get the Debian abiword
patches, mine/desktop files and manual page accepted upstream.
#526392 is long fixed, maybe you don't need the workaround in debian/rules.
You may want to consider moving to debhelper 7 dh rules.tiny style debian/rules.
You may want to switch from debian/patches/debian/rerun-automake.diff
to dh-autoreconf.
You may want to tag your patches with DEP-3 headers:
http://dep.debian.net/deps/dep3/
When using dpkg-source v3 you do not need quilt in the build-depends.
You may want to wrap the Build-Depends line since it is really long. I
usually put one build-dep per line. Possibly the same for
Depends/Recommends/etc.
You can probably drop the defoma stuff since that is from 2003.
Please check if all of debian/README.Debian still applies.
The first paragraph of debian/README.source is not needed for
dpkg-source v3 packages.
configure warnings:
configure: WARNING: unrecognized options: --disable-silent-rules,
--enable-dynamic
gcc warnings:
ut_go_file.cpp:1645: warning: 'char* check_program(const char*)'
defined but not used
ut_jpeg.cpp: In function 'bool UT_JPEG_getRGBData(const UT_ByteBuf*,
UT_Byte*, UT_sint32, bool, bool)':
ut_jpeg.cpp:197: warning: unused variable 'buffer'
xap_UnixApp.cpp: In constructor 'XAP_UnixApp::XAP_UnixApp(const char*)':
xap_UnixApp.cpp:81: warning: unused variable 'fc_inited'
fl_SectionLayout.cpp: In member function 'void
fl_HdrFtrSectionLayout::addPage(fp_Page*)':
fl_SectionLayout.cpp:3595: warning: suggest braces around empty body
in an 'else' statement
fp_Line.cpp: In member function 'bool
fp_Line::findNextTabStop(UT_sint32, UT_sint32&, eTabType&,
eTabLeader&)':
fp_Line.cpp:2922: warning: unused variable 'bRes'
fp_Line.cpp: In member function 'bool
fp_Line::findPrevTabStop(UT_sint32, UT_sint32&, eTabType&,
eTabLeader&)':
fp_Line.cpp:2951: warning: unused variable 'bRes'
fp_Line.cpp: In member function 'void
fp_Line::addDirectionUsed(UT_BidiCharType, bool)':
fp_Line.cpp:3811: warning: comparison between signed and unsigned
integer expressions
fp_Line.cpp: In member function 'void
fp_Line::removeDirectionUsed(UT_BidiCharType, bool)':
fp_Line.cpp:3831: warning: comparison between signed and unsigned
integer expressions
fp_Line.cpp: In member function 'void
fp_Line::changeDirectionUsed(UT_BidiCharType, UT_BidiCharType, bool)':
fp_Line.cpp:3866: warning: comparison between signed and unsigned
integer expressions
fp_Run.cpp: In member function 'void fp_Run::setBlockOffset(UT_uint32)':
fp_Run.cpp:998: warning: unused variable 'iOff'
fv_View_cmd.cpp:5637: warning: unused parameter 'pos'
fv_View_protected.cpp: In member function 'UT_Error
FV_View::_deleteBookmark(const char*, bool, PT_DocPosition*,
PT_DocPosition*)':
fv_View_protected.cpp:5672: warning: suggest braces around empty body
in an 'else' statement
pt_PT_DeleteSpan.cpp: In member function 'bool
pt_PieceTable::_deleteComplexSpan(PT_DocPosition&, PT_DocPosition&,
UT_Stack*)':
pt_PT_DeleteSpan.cpp:1267: warning: comparison of unsigned expression
>= 0 is always true
pt_PT_DeleteStrux.cpp: In member function 'void
pt_PieceTable::_deleteHdrFtrStruxWithNotify(pf_Frag_Strux*)':
pt_PT_DeleteStrux.cpp:663: warning: unused variable 'HdrFtrPos'
abiwidget.cpp:1042: warning: unused parameter 'pTimer'
ap_UnixDialog_Lists.cpp:154: warning: unused parameter 'widget'
ap_UnixDialog_Lists.cpp: In member function 'virtual void
AP_UnixDialog_Lists::runModal(XAP_Frame*)':
ap_UnixDialog_Lists.cpp:198: warning: unused variable 'unixapp'
ap_UnixDialog_Lists.cpp: In member function 'virtual void
AP_UnixDialog_Lists::runModeless(XAP_Frame*)':
ap_UnixDialog_Lists.cpp:249: warning: unused variable 'unixapp'
ap_UnixDialog_New.cpp:283: warning: unused parameter 'treeview'
ap_UnixDialog_Paragraph.cpp:250: warning: unused parameter 'widget'
ap_UnixDialog_Paragraph.cpp:255: warning: unused parameter 'widget'
ap_UnixToolbar_FontCombo.cpp:49: warning: unused parameter 'id'
ap_UnixToolbar_SizeCombo.cpp:37: warning: unused parameter 'id'
ap_UnixToolbar_StyleCombo.cpp:51: warning: unused parameter 'id'
ap_UnixToolbar_ZoomCombo.cpp:41: warning: unused parameter 'id'
ap_LeftRuler.cpp:857: warning: unused parameter 'ems'
ap_LeftRuler.cpp:1223: warning: unused parameter 'pView'
ap_Menu_Functions.cpp:134: warning: unused parameter 'id'
ap_Menu_Functions.cpp:152: warning: unused parameter 'id'
ap_Menu_Functions.cpp:170: warning: unused parameter 'id'
ap_Menu_Functions.cpp:188: warning: unused parameter 'id'
ap_Menu_Functions.cpp:206: warning: unused parameter 'id'
ap_Menu_Functions.cpp:286: warning: unused parameter 'id'
ap_Menu_Layouts.cpp: In member function 'EV_Menu_Layout*
XAP_Menu_Factory::CreateMenuLayout(const char*)':
ap_Menu_Layouts.cpp:304: warning: unused variable 'bResult'
ap_Toolbar_Layouts.cpp: In member function 'EV_Toolbar_Layout*
XAP_Toolbar_Factory::CreateToolbarLayout(const char*)':
ap_Toolbar_Layouts.cpp:334: warning: unused variable 'bResult'
ie_exp_AbiWord_1.cpp: In member function 'void
s_AbiWord_1_Listener::_handleRevisions()':
ie_exp_AbiWord_1.cpp:1708: warning: format '%lld' expects type 'long
long int', but argument 4 has type 'UT_uint64'
ie_imp_MsWord_97.cpp: In member function 'void IE_Imp_MsWord_97::_flush()':
ie_imp_MsWord_97.cpp:1412: warning: comparison between signed and
unsigned integer expressions
ie_imp_MsWord_97.cpp: In member function 'bool
IE_Imp_MsWord_97::_insertHeaderSection(bool)':
ie_imp_MsWord_97.cpp:6908: warning: comparison between signed and
unsigned integer expressions
ie_imp_RTF.cpp: In member function 'bool IE_Imp_RTF::_appendSpan()':
ie_imp_RTF.cpp:6177: warning: comparison between signed and unsigned
integer expressions
ie_imp_RTF.cpp: In member function 'bool IE_Imp_RTF::_insertSpan()':
ie_imp_RTF.cpp:6398: warning: comparison between signed and unsigned
integer expressions
ie_imp_RTF.cpp: In member function 'bool IE_Imp_RTF::ApplySectionAttributes()':
ie_imp_RTF.cpp:7586: warning: comparison between signed and unsigned
integer expressions
ie_imp_RTF.cpp: In member function 'bool IE_Imp_RTF::HandleAbiTable()':
ie_imp_RTF.cpp:9710: warning: format '%x' expects type 'unsigned int',
but argument 3 has type 'const void*'
../src/wp/main/gtk/libabiword.cpp: In function 'void libabiword_init_noargs()':
../src/wp/main/gtk/libabiword.cpp:47: warning: deprecated conversion
from string constant to 'char*'
ODi_Office_Styles.cpp: In member function 'void
ODi_Office_Styles::_defineAbiStyles(PD_Document*) const':
ODi_Office_Styles.cpp:311: warning: unused variable 'ok'
ODi_Style_List.cpp: In member function 'void
ODi_Style_List::redefine(PD_Document*, UT_sint32)':
ODi_Style_List.cpp:131: warning: comparison between signed and
unsigned integer expressions
ODi_Style_List.cpp:146: warning: comparison between signed and
unsigned integer expressions
AbiCollab_Packet.cpp: In member function 'virtual void
ChangeRecordSessionPacket::serialize(Archive&)':
AbiCollab_Packet.cpp:177: warning: dereferencing type-punned pointer
will break strict-aliasing rules
AbiCollab_Packet.cpp: In member function 'virtual void
ChangeStrux_ChangeRecordSessionPacket::serialize(Archive&)':
AbiCollab_Packet.cpp:396: warning: dereferencing type-punned pointer
will break strict-aliasing rules
AbiCollab_Packet.cpp: In member function 'virtual void
DeleteStrux_ChangeRecordSessionPacket::serialize(Archive&)':
AbiCollab_Packet.cpp:409: warning: dereferencing type-punned pointer
will break strict-aliasing rules
AbiCollab_Packet.cpp: In member function 'virtual void
Object_ChangeRecordSessionPacket::serialize(Archive&)':
AbiCollab_Packet.cpp:422: warning: dereferencing type-punned pointer
will break strict-aliasing rules
AbiCollab_Plugin.cpp:721: warning: 'bool s_abicollab_record(AV_View*,
EV_EditMethodCallData*)' defined but not used
AbiCollab_Plugin.cpp:748: warning: 'bool
s_abicollab_viewrecord(AV_View*, EV_EditMethodCallData*)' defined but
not used
ie_imp_GOComponent.cpp:69:2: warning: #warning should return PERFECT
only when priority is high
ie_exp_KWord_1.cpp: In member function 'void
s_KWord_1_Listener::_writeMarginSize(PT_AttrPropIndex, const char*)':
ie_exp_KWord_1.cpp:487: warning: unused variable 'bHaveProp'
LoadBindings.cpp: In function 'void LoadBindings_registerMethod()':
LoadBindings.cpp:100: warning: unused variable 'pFact'
LoadBindings.cpp: In function 'void LoadBindings_RemoveFromMethods()':
LoadBindings.cpp:172: warning: unused variable 'pFact'
LoadBindings.cpp: At global scope:
LoadBindings.cpp:84: warning: 'loadBindingID' defined but not used
LoadBindings.cpp:85: warning: 'dumpEditMethodsID' defined but not used
LoadBindings.cpp:86: warning: 'saveBindingID' defined but not used
LoadBindings.cpp:87: warning: 'szLoadBinding' defined but not used
LoadBindings.cpp:88: warning: 'szLoadBindingStatus' defined but not used
LoadBindings.cpp:89: warning: 'szDumpEditMethods' defined but not used
LoadBindings.cpp:90: warning: 'szDumpEditMethodsStatus' defined but not used
LoadBindings.cpp:91: warning: 'szSaveBinding' defined but not used
LoadBindings.cpp:92: warning: 'szSaveBindingStatus' defined but not used
...
libtool warnings:
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libfribidi.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libwmf.la' seems
to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libwmflite.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libexpat.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libxml2.la' seems
to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libenchant.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libgtk-x11-2.0.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libgdk-x11-2.0.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libatk-1.0.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libpangoft2-1.0.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libpangocairo-1.0.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libgio-2.0.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libpango-1.0.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libfreetype.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libgdk_pixbuf-2.0.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libcairo.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libgobject-2.0.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libgmodule-2.0.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libgthread-2.0.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libglib-2.0.la'
seems to be moved
libtool: link: warning:
`/usr/lib/gcc/x86_64-linux-gnu/4.4.5/../../../../lib/libjpeg.la' seems
to be moved
lintian complaints:
P: abiword-common: no-upstream-changelog
P: abiword: no-upstream-changelog
X: abiword: shlib-calls-exit usr/lib/abiword-2.8/plugins/collab.so
X: abiword: shlib-calls-exit usr/lib/abiword-2.8/plugins/mswrite.so
P: abiword-plugin-grammar: no-upstream-changelog
P: abiword-plugin-mathview: no-upstream-changelog
X: abiword-plugin-mathview: shlib-calls-exit
usr/lib/abiword-2.8/plugins/mathview.so
P: libabiword-2.8: no-upstream-changelog
X: libabiword-2.8: shlib-calls-exit usr/lib/libabiword-2.8.so
I: libabiword-2.8: no-symbols-control-file usr/lib/libabiword-2.8.so
P: libabiword-2.8-dev: no-upstream-changelog
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: