Hi,
Andreas Noteng <andreas@noteng.no> writes:
> Dear mentors,
>
> I am looking for a sponsor for my package "transgui".
>
> * Package name : transgui
> Version : 2.1.1-1
> Upstream Author : Yury Sidorov <jura@cp-lab.com>
> * URL : http://code.google.com/p/transmisson-remote-gui/
> * License : GPL-2
> Section : net
>
> It builds these binary packages:
> transgui - A front-end to remotely control Transmission
>
> The package appears to be lintian clean.
No, it didn't.
The original package I build have at least one lintian warning:
W: transgui: desktop-command-not-in-package
/usr/share/applications/transgui.desktop transgui
Which seems caused by transposed debian/link entry, the command was
replaced by a symbolic link to non-exist path.
After fix debian/link I got two additional:
W: transgui: binary-without-manpage usr/bin/transgui
E: transgui: arch-dependent-file-in-usr-share
./usr/share/transgui/transgui
I don't like the idea to put binary executable in /usr/share simply
because it searches translations in wrong place. This can be fixed by a
simple patch:
--- transgui-2.1.1.orig/restranslator.pas
+++ transgui-2.1.1/restranslator.pas
@@ -163,7 +163,7 @@ end;
function DefaultLangDir: AnsiString;
begin
- Result := ExtractFilePath(ParamStr(0)) + 'lang' + DirectorySeparator;
+ Result := '/usr/share/transgui/lang' + DirectorySeparator;
end;
function GetResStrings(Name, Value: AnsiString; Hash: longint; P: pointer): AnsiString;
Later you can work with upstream to make a proper fix to the build
system, specifying the search path at build time.
Besides the lintian warnings, there are somethings to fix, too:
- The debian/copyright file should mention the embedded source code of
the synapse project, which seems not yet packaged by Debian.
- Why prohibit dh_installmenu when you have debian/menu?
Kanru
Attachment:
pgp0MKw3zxVTL.pgp
Description: PGP signature