Re: RFS: ase - Allegro Sprite Editor
Hi,
On Sat, Sep 25, 2010 at 8:39 AM, Oscar Morante <oscar@morante.eu> wrote:
> I am looking for a sponsor for my package "ase".
[...]
Here's me review.
The package FTBFS on x86_64 due to some pointer to int conversion.
src/widgets/groupbut.cpp: In function 'int' group_button_get_selected(Widget*)':
src/widgets/groupbut.cpp:104: error: cast from 'void*' to 'int' loses precision
src/widgets/groupbut.cpp: In function 'void' group_button_select(Widget*, int)':
src/widgets/groupbut.cpp:113: error: cast from 'void*' to 'int' loses precision
src/widgets/groupbut.cpp: In function 'int select_button(Widget*, int)':
src/widgets/groupbut.cpp:140: error: cast from 'void*' to 'int' loses precision
make[1]: *** [obj/unix/groupbut.o] Error 1
make[1]: Leaving directory `/tmp/buildd/ase-0.8.1-beta'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2
You should describe where you get the upstream release/tarball in
debian/copyright.
The files under src/jinete and src/tests/jinete are BSD licensed
(except src/jinete/miregion.cpp which is MIT licensed), they should
mentioned in debian/copyright.
The files under third_party/freetype should be mentioned, too.
You could run licensecheck (from devscripts) to get a rough list of
the missing copyright/license notice:
licensecheck -r --copyright ase-0.8.1-beta
And the version number 0.8.1-beta-1 is a bit problematic, because when
the final release comes out, it will be 0.8.1-1 which is considered
less than 0.8.1-beta-1. I would use 0.8.1~beta-1 instead.
Cheers,
Kanru
Reply to: