[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libsmf



On Mon, Apr 05, 2010 at 06:14:25PM +0800, Paul Wise wrote:
> A review:
> 
> The first 3 symbols in the symbols file look like they might be
> internal symbols that should not be exported, is that the case?
> 
> http://gcc.gnu.org/wiki/Visibility

It seems that the symbols where supposed to be internal originally
but they are documented[0] and used by denemo[1][2] (my another ITA)[2].

Which could be the right way to proceed in this case?.

1. Keep it "as is" right now, and ask to upstream to clean up the API
fot the next version? (to make clear which symbols are public and
private).

2. Request to upstream to change the API (doc and visibility) and then
   request to denemo upstream to update their software, and then make
   the packages.

3. another?

BTW, Denemo is already in debian, but is using an embedded copy of
libsmf.

> The SONAME should not be added to the -dev or utils packages. I'd
> recommend naming the utils package smf-utils
...

Changed :).

http://mentors.debian.net/debian/pool/main/l/libsmf/libsmf_1.3-1.dsc

Thanks for your help.

[0] http://libsmf.sourceforge.net/api/globals.html
[1] http://ur1.ca/u5ng
[2] http://denemo.org
[3] http://mentors.debian.net/debian/pool/main/d/denemo/denemo_0.8.14-1.dsc


-- 
Josué M. Abarca S.
Vos mereces Software Libre.
PGP key 4096R/70D8FB2A 2009-06-17
fingerprint = B3ED 4984 F65A 9AE0 6511  DAF4 756B EB4B 70D8 FB2A

Attachment: signature.asc
Description: Digital signature


Reply to: