[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libpqstego



Thanks for your comments.

Thus wrote Ruben Molina (rmolina@udea.edu.co) [08.12.30 19:51]:
> Hi Christian!
> 
> > I am looking for a sponsor for my packages "libpqstego" and "pqstego".
> 
> I'm not a DD so I cannot sponsor uploads, but here are some comments:
> 
> Both packages are tagged as version: 0.0.0, do you really think they are
> ready to be included in Debian? 

I hope so, the algorithm of J. Fridrich [1] is working and diffrent
checks of the source (ie. valgrind) didn't report any problems. 
 
> In both packages you are shipping the debian/ stuff in the sources, so
> the *.diff.gz are empty :S.
> 
> $ dpkg-source -x libpqstego_0.0.0-1.dsc
> dpkg-source: warning: diff `./libpqstego_0.0.0-1.diff.gz' doesn't
> contain any patch
> 
> $ dpkg-source -x pqstego_0.0.0-1.dsc
> dpkg-source: warning: diff `./pqstego_0.0.0-1.diff.gz' doesn't contain
> any patch
> 
> As you are upstream, you should separate the debian/ dir from the
> sources. If you release a *.tar.gz without debian/ dir, and then you are
> prepare the debian package, the changes needed are stored in the
> *.diff.gz file...

Ok, I will separate them.
 
> Check your packages with lintian adding the -I option:
> 
> $ lintian -I libpqstego_0.0.0-1_i386.changes 
> I: libpqstego source: package-lacks-versioned-build-depends-on-debhelper
> 7
> I: libpqstego0: no-symbols-control-file usr/lib/libpqstego.so.0.0.0
> I: libpqstego0-dev: extended-description-is-probably-too-short
> I: libpqstego0-dbg: extended-description-is-probably-too-short
> 
> $ lintian -IE pqstego_0.0.0-1_i386.changes 
> I: pqstego-dbg: extended-description-is-probably-too-short
> I: pqstego: extended-description-is-probably-too-short
> 
> you should work on this...
> 
> And yes... your extended descriptions are for sure *too* short :) 
> BTW, check your short descriptions too, after reading 6.2.1-6.2.3 on
> Developers Reference [1]
> 
> [1] http://www.debian.org/doc/developers-reference/

A better short/long description is in progress. How can I generate such
a symbols file in debian/rules?

> libpqstego builds fine under pbuilder, but libpqstego0-dev and
> libpqstego0-dbg fails on piuparts... I haven't tested why, but please
> check this too... Uhmm... didn't tried for pqstego...

Will check that.

> Uhmm BTW, I'm not sure about versioning the package names for -dev and
> -dbg...  check the Library Packaging Guide too [2] :)
> 
> [2] http://www.netfort.gr.jp/~dancer/column/libpkg-guide/

In the guide they use the example "libfooX-dev" 

> Uhmm, finally, maybe both projects can be merged... (?)

Hmm I wanted to separate them, as I use the library in some other projects
too.
 
> OK. That's what I can see after a fast checking...
> 
> Thanks for your interest on Debian :)
> 
> Ruben Molina
> 
> > Ps.: Merry Chrismas, and a Happy New Year

[1] Perturbed Quantization Steganography with Wet Paper Codes, with M. Goljan and D. Soukal, Proc. ACM Multimedia Security Workshop, Magdeburg, Germany, September 20-21, pp. 4-15, 2004

-- 
-----------------------------------------------------------------------
PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
Key ID: 0x61E7150B - 4EFC 3FA6 FB8E 2BD5 CA11  6F15 F557 6B5D 61E7 150B

Christian Kuka
ckuka@madkooky.de 

Attachment: signature.asc
Description: Digital signature


Reply to: