Re: request for review: lbzip2-0.17-1

[ERSEK Laszlo <lacos@caesar.elte.hu>]

On Wed, 4 Nov 2009, Paul Wise wrote:

> Reviewed and uploaded.

Thank you!


> Not sure if you've used zzuf before, but you might want to use it to
> discover possible bugs that could lead to crashes/etc in lbzip2.

Thanks for the tip. I didn't use zzuf, but I did do fuzz testing, as early 
as 0.02. I dedicated a whole section to this in the README ("Decompression 
robustness"). Also, search for "lbzip2" under [0].


> helgrind (and the other valgrind tools) might be useful to find bugs:
>
> http://valgrind.org/info/tools.html#helgrind

I've used several valgrind tools for testing (no bugs were reported).

A side note: as written in [1], "7.5. Hints and Tips for Effective Use of 
Helgrind":

    3. Avoid POSIX condition variables.

Condition variables are at the core of lbzip2. I published an article on 
this topic in the form of a reddit self-post, see [2].

Thanks again!
lacos

[0] http://www.cert.fi/haavoittuvuudet/joint-advisory-archive-formats.html
[1] http://valgrind.org/docs/manual/hg-manual.html#hg-manual.effective-use
[2] http://www.reddit.com/r/programming/comments/9ynxv/utter_verbiage_how_to_design_condition_variables/