Re: RFS: kplayer

[David Palacio <dpalacio@uninorte.edu.co>]

On Sábado 09 Mayo 2009 10:43:24 Patrick Matthäi escribió:
> David Palacio schrieb:
> > Dear mentors,
> >
> > I am looking for a sponsor for my package "kplayer".
> >
> > * Package name    : kplayer
> >   Version         : 1:0.7-1
> >   Upstream Author : kiriuja <kiriuja@users.sourceforge.net>
> > * URL             : http://kplayer.sourceforge.net
> > * License         : GPL version 3
> >   Section         : video
> >
> > It builds these binary packages:
> > kplayer    - A KDE media player based on MPlayer
> > kplayer-dbg - kplayer debug symbols
> >
> > The package can be found on mentors.debian.net:
> > - URL: http://mentors.debian.net/debian/pool/main/k/kplayer
> > - Source repository: deb-src http://mentors.debian.net/debian unstable
> > main contrib non-free
> > - dget
> > http://mentors.debian.net/debian/pool/main/k/kplayer/kplayer_0.7-1.dsc
>
> Hello,
>
> why is this is debian native package? This is wrong
>
> * debian/control:
> - The kplayer-dbg package is in the wrong section
> - The bugs field is useless here
> - Please add the homepage field
>
> * debian/kplayer.install:
> - The single dots are a bit useless
>
> * debian/copyright:
> - You may leave your own copyright there
> - The files in doc/ are licensed with the GFDL, see COPYING-DOCS
>
> * debian/patches and debian/kplayer.1:
> - Have you sent them to upstream?
> - Patch descriptions are missing in their f. headers
>
> Also please fix those lintian warnings:
> : kplayer: manpage-has-errors-from-man usr/share/man/man1/kplayer.1.gz
>
> 9: warning: `.SH' not defined
> P: kplayer: copyright-refers-to-symlink-license
> usr/share/common-licenses/GPL
> I: kplayer: desktop-entry-contains-encoding-key
> /usr/share/applications/kde4/kplayer.desktop:2 Encoding
> P: kplayer: no-homepage-field
> P: kplayer-dbg: copyright-refers-to-symlink-license
> usr/share/common-licenses/GPL
> I: kplayer-dbg: extended-description-is-probably-too-short
All those are fixed now. Patches are already on upstream's svn.

> * debian/copyright:
> - You may leave your own copyright there
> - The files in doc/ are licensed with the GFDL, see COPYING-DOCS
They are not being installed. Or do you want them out of sources too?

Thanks.

David Palacio.