Re: RFS: plotmm
On Fri, Oct 31, 2008 at 7:45 AM, M G Berberich
<berberic@fmi.uni-passau.de> wrote:
> - dget http://mentors.debian.net/debian/pool/main/p/plotmm/plotmm_0.1.2-1.dsc
A review of your source package:
Package descriptions need work, please ask for a review on the
debian-l10n-english email list.
Since the shared lib package is usually just installed automatically,
the description doesn't need to contain as many details.
You did not file an ITP, please do so.
You don't seem to use any debhelper 7 features, please revert the
dependency and compat level to version 5.
The upstream NEWS file is empty, please do not ship it.
The upstream README file contains no information relevant to Debian
users that isn't present elsewhere, no need to ship it in the .deb.
Several files are named incorrectly: debian/plotmm0.dirs
debian/shlibs.plotmm debian/plotmm-dev.dirs debian/plotmm-dev.install
debian/plotmm0.install
Please remove junk from the diff.gz: debian/plotmm0.debhelper.log
debian/plotmm0.substvars debian/plotmm0.postinst.debhelper
debian/plotmm-dev.debhelper.log debian/plotmm0.postrm.debhelper
Upstream seems to confuse the difference between NEWS and ChangeLog,
please educate them about it (GNU standards docs contain that
information).
Please remove commented out stuff from debian/rules.
Please fix the lintian warnings output by lintian -i -I:
I: plotmm source: debian-watch-file-is-missing
W: plotmm source: out-of-date-standards-version 3.7.3 (current is 3.8.0)
Please test it in pbuilder/cowbuilder and lintian check the results.
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: