Tim Retout <tim@retout.co.uk> (23/06/2008):
> This contains the GNU Coding Standards, as well as 'Information For
> Maintainers of GNU Software', two useful documents even if you are not
> a GNU maintainer. I suggested to upstream a few months ago that they
> could relicense the latter under the GFDL (without invariant
> sections), and the Debian package can now be moved from non-free into
> main.
Nice!
> I also added doc-base registration files, so this upload should fix
> all known bugs for the package.
Looks like.
> I would be glad if someone uploaded this package for me.
Before that, I'd like you to address the following points:
- Maybe the Homepage could move from https:// to http://?
- What about making doc-base files less “personal”? You don't really
need to point fingers at the reader and keep using “you” every
sentence. :) Not a high priority thing, but that'd be nice if it were
considered as some point.
- You surely don't need debian/dirs.
- Nor an empty debian/docs, but see below.
- Why are you setting SHELL=/bin/bash instead of just not using
bashisms? You could e.g. put the whole file list in debian/docs
instead of using (double) {} constructs in the dh_installdocs call.
- You could get rid of commented calls in debian/rules as well.
- Your configure/configure-stamp targets aren't doing anything, why not
deleting them completly?
- You could finish the “refresh:” target with an “exit 1” so that you
easily spot that it's getting called (by mistake) during a real
build, because buildds aren't supposed to have net access during the
build.
- Did you notice the following? (from lintian)
E: gnu-standards: doc-base-file-references-missing-file gnu-maintainers-information:24 /usr/share/info/maintain.info.gz
E: gnu-standards: doc-base-file-references-missing-file gnu-maintainers-information:25 /usr/share/info/maintain.info.gz
E: gnu-standards: doc-base-file-references-missing-file gnu-coding-standards:24 /usr/share/info/standards.info.gz
E: gnu-standards: doc-base-file-references-missing-file gnu-coding-standards:25 /usr/share/info/standards.info.gz
After the build, I got: kibi@evy:/tmp/gnu-standards$ find -name '*.info'
./standards.info
./maintain.info
- I had a very quick look at your git history, you may want to use “dch
-t” when modifying the history, so as to get rid of the (IMHO) noisy
trailer line change on every commit. That makes interactive rebase a
bit easier, as well as cherry-picking (although I'm not sure you will
ever need it on this particular package). Of course, if the timestamp
update is intended, feel free to keep doing so, that's just a mere
suggestion. (I'm BTW not using dch -t, but rather dch -a, or manual
modifications to debian/changelog, and only modifying the timestamp,
through dch -r, right before the upload.)
- You're welcome to target “unstable” if your next upload to mentors
addresses the above points.
Mraw,
KiBi.
Attachment:
signature.asc
Description: Digital signature