Re: RFS: libvrb -- Virtual Ring Buffer library
On (26/09/06 22:09), Székelyi Szabolcs wrote:
> Dear mentors,
>
> I am looking for a sponsor for my package "libvrb". This is an update to
> the (so far unsponsored) previous version 0.5.1-1.
>
Hi, I cannot sponsor, but I have a few comments for you.
* The dev-ref recommends indenting the Homepage: pseudo-field by two
spaces.
* Do you need Replaces: libvrb-dev as well?
* Please move away from using ${Source-Version} in debian/control
http://lists.debian.org/debian-mentors/2006/09/msg00228.html
* Drop the blank line from libvrb0-dev.install
* You don't need a - in front of rm -rf as it wont fail if the dir is
not present.
* Why are you not using the configure target? Your current setup makes
cross-compiling harder, and making a debug version of the package
difficult as well.
* Please add a watch file.
* Lintian gives a few
I: vbuf: hyphen-used-as-minus-sign usr/share/man/man1/vbuf.1.gz:66
that you might like to fix.
The binary packages look good though.
James
--
James Westby -- GPG Key ID: B577FE13 -- http://jameswestby.net/
seccure key - (3+)k7|M*edCX/.A:n*N!>|&7U.L#9E)Tu)T0>AM - secp256r1/nistp256
Reply to: