Re: Bug#89433: I want to adopt osh
Oohara Yuuma <oohara@libra.interq.or.jp> cum veritate scripsit:
> My .deb of osh is available at:
> http://www.interq.or.jp/libra/oohara/debian-unofficial/osh_1.7.orig.tar.gz
> http://www.interq.or.jp/libra/oohara/debian-unofficial/osh_1.7-9.diff.gz
> http://www.interq.or.jp/libra/oohara/debian-unofficial/osh_1.7-9.dsc
> http://www.interq.or.jp/libra/oohara/debian-unofficial/osh_1.7-9_i386.deb
Some things I noticed:
o MAXPATHLEN is not available on some systems.
p Is writing something like:
Note that this license is not compatible with the GPL. This means that
you can't redistribute the binary of osh if it is complied with libraries
licensed under the GPL. The debian package is compiled with libc6 and
libncurses5, which seem to have no problem to me (Oohara Yuuma), but I am
not a lawyer.
into a Debian pacakge copyright file a good idea?
o DEB_BUILD_OPTIONS="debug,nostrip" && debuild
will never work, because debuild does unset env vars.
DEB_BUILD_OPTIONS="xxxx" dpkg-buildpackage
DEB_BUILD_OPTIONS="xxxx" debian/rules
should work though.
o Why are you commenting out static char *rcsid ?
o Adding extra {} in if statements does not seem to help anything
o What is the point of:
+/*
fatal(mes)
+*/
+int fatal(mes)
and other changes, with commented-out changes?
o Why are you building the binary with -O3 -fomit-frame-pointer?
o are you sending the mods to the upstream ? / have you
contacted the upstream ?
My personal feeling is that I don't like large diffs,
and Debian-specific modifications.
regards,
junichi
--
dancer@debian.org : Junichi Uekawa http://www.netfort.gr.jp/~dancer
GPG Fingerprint : 17D6 120E 4455 1832 9423 7447 3059 BF92 CD37 56F4
Reply to: