Bug#697873: live-boot: Easy fix for broken persistence-label parameter

[Mike Gach <gach.mqt@gmail.com>]

Package: live-boot
Version: 3.0~a35-1
Severity: important
Tags: patch

Dear Maintainer,

I have a persistent Live Wheezy 7.0~b4 working with the file name 'persistence'. If I use persistence-label=xyz and make a file named 'persistence-xyz' (with a proper live-persistence.conf file in it), then when the system is rebooted, the system will not be using either persistence file.

The porblem exists in live-boot 3.0~a35-1, 3.0~b4-1, and 3.0~b11-1

There is an easy fix. The problem is in cmdline.sh for 3.0~a and 9990-cmdline-old for 3.0~b. When the parameter is parsed, the label is applied to the variables without prefixes.

Current code:
	persistence-label=*)
		old_live_overlay_label="${_PARAMETER#persistence-label=*}"
		old_home_overlay_label="${_PARAMETER#persistence-label=*}"
		custom_overlay_label="${_PARAMETER#persistence-label=*}"
 		;;

Fixed code:
	persistence-label=*)
		old_live_overlay_label="live-rw-${_PARAMETER#persistence-label=*}"
		old_home_overlay_label="home-rw-${_PARAMETER#persistence-label=*}"
		custom_overlay_label="persistence-${_PARAMETER#persistence-label=*}"
		;;

I have tested this on 3.0~a35-1 and 3.0~b11-1 with keys that boot multiple images each with their own persistence file.

This is my first bug report. If I missed any information or need to do some specific testing, I would be happy to.

-- Package-specific info:

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages live-boot depends on:
ii  live-boot-initramfs-tools [live-boot-backend]  3.0~a35-1

Versions of packages live-boot recommends:
ii  eject          2.1.5+deb1+cvs20081104-11
ii  file           5.11-2
ii  live-boot-doc  3.0~a35-1
ii  rsync          3.0.9-3
ii  uuid-runtime   2.20.1-5.2

Versions of packages live-boot suggests:
pn  cryptsetup    <none>
pn  curlftpfs     <none>
pn  httpfs2       <none>
pn  unionfs-fuse  <none>
ii  wget          1.13.4-3

-- no debconf information