Bug#894356: lintian: udev-rule-missing-subsystem false positives when SUBSYSTEM GOTO is not the last GOTO

[Thomas Dallmair <dev@thomas-dallmair.de>]

Package: lintian
Version: 2.5.79
Severity: normal

Dear Maintainer,

Last week I started to prepare a new package for inclusion in Buster.
Unfortunately, lintian reports 18 warnings on the following valid udev
rules file:

    https://github.com/knxd/knxd/blob/master/debian/knxd.udev

Line 22 sends everything except subsystem "usb" to "knxd_end", so in 
lines
23-62 the subsystem is clearly defined. Nevertheless, lintian warns 
about
every other line in the range 26-60:

    W: knxd: udev-rule-missing-subsystem 
lib/udev/rules.d/60-knxd.rules:26
    vendor/product matching missing SUBSYSTEM specifier
    [...]
    W: knxd: udev-rule-missing-subsystem 
lib/udev/rules.d/60-knxd.rules:60
    vendor/product matching missing SUBSYSTEM specifier

Currently lintian remembers the last goto rule it encounters and checks
whether that was a subsystem goto rule on every device rule it 
processes.
Unfortunately, this approach requires the subsystem goto rule to be the
last one right before the device rules. However, there is another goto
rule between these in the affected udev file, therefore lintian does not
recognize this situation.

Please pull the patch including updated test case to catch this from my
fork:

    https://salsa.debian.org/dallmair-guest/lintian.git, branch
    udev-rules-subsystem-goto

Thanks.
-Thomas


-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.14.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils                          2.30-7
ii  bzip2                             1.0.6-8.1
ii  diffstat                          1.61-1+b1
ii  dpkg                              1.19.0.5
ii  file                              1:5.32-2
ii  gettext                           0.19.8.1-4
ii  intltool-debian                   0.35.0+20060710.4
ii  libapt-pkg-perl                   0.1.33
ii  libarchive-zip-perl               1.60-1
ii  libclass-accessor-perl            0.51-1
ii  libclone-perl                     0.39-1
ii  libdpkg-perl                      1.19.0.5
ii  libemail-valid-perl               1.202-1
ii  libfile-basedir-perl              0.07-1
ii  libipc-run-perl                   0.96-1
ii  liblist-moreutils-perl            0.416-1+b3
ii  libparse-debianchangelog-perl     1.2.0-12
ii  libperl5.26 [libdigest-sha-perl]  5.26.1-5
ii  libtext-levenshtein-perl          0.13-1
ii  libtimedate-perl                  2.3000-2
ii  liburi-perl                       1.73-1
ii  libxml-simple-perl                2.24-1
ii  libyaml-libyaml-perl              0.69+repack-1
ii  man-db                            2.8.2-1
ii  patchutils                        0.3.4-2
ii  perl                              5.26.1-5
ii  t1utils                           1.41-2
ii  xz-utils                          5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b4

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  dpkg-dev               1.19.0.5
ii  libhtml-parser-perl    3.72-3+b2
ii  libtext-template-perl  1.47-1

-- no debconf information