Bug#720986: [pkg-php-pear] Bug#720986: Correct condition for pecl-package-requires-build-dependency

[Mathieu Parent <math.parent@gmail.com>]

2013/8/26 Prach Pongpanich <prachpub@gmail.com>:
> Package: lintian
> Version: 2.5.15
> Severity: normal
> Tags: patch
> X-Debbugs-CC: pkg-php-pear@lists.alioth.debian.org
>
> Dear maintainers,
>
> I provide a patch to fix this tags.
>
> Tag: pecl-package-requires-build-dependency
> Info: The package is a PECL package but its control file doesn't have
>  php5-dev or dh-php5 as a build dependency.

According to Ondřej:

<<
Maybe the logic should be:

If you depend on php5-dev, you should either also depend and use dh_php5
(or you should call php5{en,dis}mod in your postinst scripts and override
the lintian warning).
>>

Ref: http://lists.alioth.debian.org/pipermail/pkg-php-pear/2013-July/001481.html

I think the current test can be improved. But your patch is not good either.

The php5-dev dependency is correct (but should probably be put outside
the pkg-php-tools builddep block, in a if package_xml block).

The dh-php5 dep should be changed to:
- if --with=php5 in debian/rules -> then it should builddep on dh-php5 (warning)
- if builddep on dh-php5 -> then it should --with=php5 in debian/rules (warning)
- otherwise suggest depending on dh-php5 (info)


-- 
Mathieu