[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#642027: [checks/source-copyright] false-positive unknown-copyright-format-uri



* Jakub Wilk <jwilk@debian.org>, 2011-09-18, 19:15:
These are false positives:
P: libmime-lite-perl source: unknown-copyright-format-uri http://svn.debian.org/viewvc/dep/web/deps/dep5.mdwn?rev=135
P: gdebi source: unknown-copyright-format-uri http://svn.debian.org/viewvc/dep/web/deps/dep5.mdwn?revision=174

Here's a patch for another false positive:
P: gracie source: unversioned-copyright-format-uri http://svn.debian.org/wsvn/dep/web/deps/dep5.mdwn?op=file;rev=135

--
Jakub Wilk
diff -r b677637f44b8 checks/source-copyright
--- a/checks/source-copyright	Sat Oct 08 08:42:44 2011 +0200
+++ b/checks/source-copyright	Sat Oct 08 12:36:31 2011 +0000
@@ -103,11 +103,11 @@
         }
         elsif ($uri =~ s,^http://svn\.debian\.org/wsvn/dep/web/deps/dep5\.mdwn\b,,) {
             $version = '0+svn';
-            $uri =~ m,^\?(?:\S+&)?rev=(\d+)(?:&\S+)?$, and $version = "$version~$1";
+            $uri =~ m,^\?(?:\S+[&;])?rev=(\d+)(?:[&;]\S+)?$, and $version = "$version~$1";
         }
         elsif ($uri =~ s,^http://(?:svn|anonscm)\.debian\.org/viewvc/dep/web/deps/dep5\.mdwn\b,,) {
             $version = '0+svn';
-            $uri =~ m,^\?(?:\S+&)?(?:pathrev|revision|rev)=(\d+)(?:&\S+)?$, and $version = "$version~$1";
+            $uri =~ m,^\?(?:\S+[&;])?(?:pathrev|revision|rev)=(\d+)(?:[&;]\S+)?$, and $version = "$version~$1";
         }
         elsif ($uri =~ m,^http://www\.debian\.org/doc/(?:packaging-manuals/)?copyright-format/(\d+\.\d+)$,) {
             $version = $1;

Reply to: