[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, master, updated. 2.4.3-174-g6c40856



The following commit has been merged in the master branch:
commit 6fee33bdffa7894c6048b4a5f81aec21d6795961
Author: Niels Thykier <niels@thykier.net>
Date:   Wed Jan 26 12:20:54 2011 +0100

    PerlCritic warnings fixed in Lintian::Command{,::Simple}

diff --git a/lib/Lintian/Command.pm b/lib/Lintian/Command.pm
index 84d695d..5317a9b 100644
--- a/lib/Lintian/Command.pm
+++ b/lib/Lintian/Command.pm
@@ -216,7 +216,7 @@ sub spawn {
 	$opts->{success} = 0;
 	$opts->{exception} = $@;
     } elsif ($opts->{fail} eq 'error'
-	     and !$opts->{success}) {
+	     and not $opts->{success}) {
 	require Util;
 	if ($opts->{description}) {
 	    Util::fail("$opts->{description} failed with error code ".
@@ -225,7 +225,7 @@ sub spawn {
 	    Util::fail("$cmds[0][0] failed with error code ".
 		       $opts->{harness}->result);
 	} else {
-	    Util::fail("command failed with error code ".
+	    Util::fail('command failed with error code '.
 		       $opts->{harness}->result);
 	}
     }
@@ -277,13 +277,13 @@ sub reap {
 	    $opts->{success} = 0;
 	    $opts->{exception} = $@;
 	} elsif ($opts->{fail} eq 'error'
-		 and !$opts->{success}) {
+		 and not $opts->{success}) {
 	    require Util;
 	    if ($opts->{description}) {
 		Util::fail("$opts->{description} failed with error code ".
 			   $opts->{harness}->result);
 	    } else {
-		Util::fail("command failed with error code ".
+		Util::fail('command failed with error code '.
 			   $opts->{harness}->result);
 	    }
 	}
diff --git a/lib/Lintian/Command/Simple.pm b/lib/Lintian/Command/Simple.pm
index 953c5a9..e17fa23 100644
--- a/lib/Lintian/Command/Simple.pm
+++ b/lib/Lintian/Command/Simple.pm
@@ -196,7 +196,7 @@ results.
 sub wait {
     my ($self, $pid);
 
-    if (ref $_[0] eq "Lintian::Command::Simple") {
+    if (ref $_[0] eq 'Lintian::Command::Simple') {
 	$self = shift;
 	$pid = $self->{'pid'};
     } else {
@@ -227,7 +227,7 @@ sub wait {
 	    if (wantarray) {
 		return ();
 	    } else {
-		return undef;
+		return;
 	    }
 	}
 
@@ -238,7 +238,7 @@ sub wait {
 	    if (wantarray) {
 		return ();
 	    } else {
-		return undef;
+		return;
 	    }
 	}
 
@@ -294,7 +294,7 @@ signaled (and per the above description, reaped.)
 sub kill {
     my ($self, $pid);
 
-    if (ref $_[0] eq "Lintian::Command::Simple") {
+    if (ref $_[0] eq 'Lintian::Command::Simple') {
 	$self = shift;
 	$pid = $self->pid();
     } elsif (ref $_[0]) {

-- 
Debian package checker


Reply to: