[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#394937: marked as done (warn about trailing whitespace)



Your message dated Sat, 28 Oct 2006 11:46:05 -0700
with message-id <87slh89t3m.fsf@windlord.stanford.edu>
and subject line Bug#394937: warn about trailing whitespace
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: lintian
Severity: wishlist

Lintian should warn about trailing whitespace in at least the Debian
files part of packages, as per Bug#177523:

>>>>> "J" == Justin Pryzby <justinpryzby@users.sourceforge.net> writes:

J> These are all (except codecs.conf.gz) Debian files, and it would be appropriate
J> for lintian to check for them.  However, when you submitted a bug against
J> lintian, it was apparently to "check program source code to make sure that it
J> doesn't create any syslog entries with trailing whitespace".

J> These are two separate issues, both of which might warrent bug reports.  The
J> "logfiles" bug, however, should be submitted against the individual packages,
J> since there is no conceivable way for lintian (or such) to check for it,
J> whereas the "Debian files" bug might reasonably be implemented in such a tool.

OK, hereby submitting the latter item.

pcregrep '\s$' is right regexp to catch it.
or perl -nlwe 'print if /\s$/' to avoid depending on pcregrep.
Add warning message with file name and line number.

Maybe also lintian could warn of blank lines at end of files too...


--- End Message ---
--- Begin Message ---
Dan Jacobson <jidanni@jidanni.org> writes:

> Package: lintian
> Severity: wishlist

> Lintian should warn about trailing whitespace in at least the Debian
> files part of packages, as per Bug#177523:

I closed a duplicate of this bug against lintian earlier and I'm afraid
I'm going to close it again.  This is just too picky for lintian to ever
want to tackle, and Dan, while I appreciate that this is something that
you care a lot about, you seem to be the only person who is filing this
bug so I don't think leaving it open tagged wontfix is very helpful.

lintian does diagnose some things that don't cause problems but are still
useful to improve as a matter of style or strict policy compliance, but
trailing whitespace in general on all files goes beyond that and into the
realm of picky little notices that cause people to stop using lint
software rather than fix the other, more serious problems that they catch.
The small difference this would make across the entire archive would be
dwarfed, in either direction, by a small change to gcc's optimizer.

If there are specific, common files where trailing whitespace causes
problems (such as misinterpretation of the file), please file a more
specific bug describing what those files are.

Thanks.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>

--- End Message ---

Reply to: