[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://mopidy/{mopidy.templates}



Please find, for review, the debconf templates and packages descriptions for the mopidy source package.

This review will last from Monday, July 21, 2014 to Thursday, July 31, 2014.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- mopidy.old/debian/mopidy.templates	2014-07-12 07:22:16.176133080 +0200
+++ mopidy/debian/mopidy.templates	2014-07-17 07:52:14.518298353 +0200
@@ -3,11 +3,11 @@
 Default: false
 _Description: Should the Mopidy server be started at boot?
  The Mopidy server can be run as a system service, automatically starting
- at boot. It will be listening to MPD connections at port 6600 and HTTP
- connections at port 6680. By default, it will only accept connections from
- localhost.
+ at boot. It will be listening to MPD connections on port 6600 and HTTP
+ connections on port 6680. By default, it will only accept connections from
+ the local machine.

s/at port/on port

light unjargonification : localhost -> the local machine

  .
  You have the option of starting the Mopidy server automatically on system
  boot. If in doubt, it is suggested to not start it automatically on boot.
  .
- This setting can be modified later by running 'dpkg-reconfigure mopidy'.
+ This setting can be modified later by running "dpkg-reconfigure mopidy".

Strandard debian-l10n-english use of quotes.....

--- mopidy.old/debian/control	2014-07-12 07:22:16.176133080 +0200
+++ mopidy/debian/control	2014-07-21 06:54:47.813336165 +0200
@@ -34,9 +34,10 @@
     mopidy-doc
 Description: music server with support for MPD/HTTP clients
  Mopidy is a music server which can play music both from multiple sources, like
- your local hard drive, radio streams, and from Spotify and SoundCloud.
- Searches combines results from all music sources, and you can mix tracks from
- all sources in your play queue. Your playlists from Spotify or SoundCloud are
+ the local hard drive, radio streams, and from Spotify and SoundCloud.
+ .
+ Searches combines results from all music sources, and tracks can be mixed from
+ all sources in the play queue. Spotify or SoundCloud playlists are
  also available for use.

Split in two paragraphs for readability.

Unpersonnalize (drop "your")
 
 Package: mopidy-doc
@@ -49,6 +50,6 @@
 Replaces: mopidy (<< 0.7.3-2)
 Description: music server with support for MPD/HTTP clients - documentation
  Mopidy is a music server which can play music both from multiple sources, like
- your local hard drive, radio streams, and from Spotify and SoundCloud.
+ the local hard drive, radio streams, and from Spotify and SoundCloud.
  .
- The packages includes documentation for Mopidy.
+ This package provides the documentation for Mopidy.

Unpersonnalize.

STandard dle use : "this package provides"

-- 

Template: mopidy/daemon
Type: boolean
Default: false
_Description: Should the Mopidy server be started at boot?
 The Mopidy server can be run as a system service, automatically starting
 at boot. It will be listening to MPD connections on port 6600 and HTTP
 connections on port 6680. By default, it will only accept connections from
 the local machine.
 .
 You have the option of starting the Mopidy server automatically on system
 boot. If in doubt, it is suggested to not start it automatically on boot.
 .
 This setting can be modified later by running "dpkg-reconfigure mopidy".
--- mopidy.old/debian/mopidy.templates	2014-07-12 07:22:16.176133080 +0200
+++ mopidy/debian/mopidy.templates	2014-07-17 07:52:14.518298353 +0200
@@ -3,11 +3,11 @@
 Default: false
 _Description: Should the Mopidy server be started at boot?
  The Mopidy server can be run as a system service, automatically starting
- at boot. It will be listening to MPD connections at port 6600 and HTTP
- connections at port 6680. By default, it will only accept connections from
- localhost.
+ at boot. It will be listening to MPD connections on port 6600 and HTTP
+ connections on port 6680. By default, it will only accept connections from
+ the local machine.
  .
  You have the option of starting the Mopidy server automatically on system
  boot. If in doubt, it is suggested to not start it automatically on boot.
  .
- This setting can be modified later by running 'dpkg-reconfigure mopidy'.
+ This setting can be modified later by running "dpkg-reconfigure mopidy".
--- mopidy.old/debian/control	2014-07-12 07:22:16.176133080 +0200
+++ mopidy/debian/control	2014-07-21 06:54:47.813336165 +0200
@@ -34,9 +34,10 @@
     mopidy-doc
 Description: music server with support for MPD/HTTP clients
  Mopidy is a music server which can play music both from multiple sources, like
- your local hard drive, radio streams, and from Spotify and SoundCloud.
- Searches combines results from all music sources, and you can mix tracks from
- all sources in your play queue. Your playlists from Spotify or SoundCloud are
+ the local hard drive, radio streams, and from Spotify and SoundCloud.
+ .
+ Searches combines results from all music sources, and tracks can be mixed from
+ all sources in the play queue. Spotify or SoundCloud playlists are
  also available for use.
 
 Package: mopidy-doc
@@ -49,6 +50,6 @@
 Replaces: mopidy (<< 0.7.3-2)
 Description: music server with support for MPD/HTTP clients - documentation
  Mopidy is a music server which can play music both from multiple sources, like
- your local hard drive, radio streams, and from Spotify and SoundCloud.
+ the local hard drive, radio streams, and from Spotify and SoundCloud.
  .
- The packages includes documentation for Mopidy.
+ This package provides the documentation for Mopidy.
Source: mopidy
Section: sound
Priority: optional
Maintainer: Stein Magnus Jodal <stein.magnus@jodal.no>
Build-Depends:
    debhelper (>= 8.0.0),
    python (>= 2.7),
    python-setuptools,
    python-sphinx (>= 1.0),
    python-pygraphviz
Standards-Version: 3.9.5
Homepage: http://www.mopidy.com/
Vcs-Git: git://github.com/mopidy/mopidy.git
Vcs-Browser: https://github.com/mopidy/mopidy
X-Python-Version: >= 2.7

Package: mopidy
Architecture: all
Depends:
    ${misc:Depends},
    ${python:Depends},
    adduser,
    debconf,
    lsb-base,
    gstreamer0.10-plugins-good,
    python-gst0.10
Recommends:
    gstreamer0.10-alsa,
    gstreamer0.10-plugins-ugly,
    gstreamer0.10-tools,
    python-cherrypy3,
    python-ws4py
Suggests:
    mopidy-doc
Description: music server with support for MPD/HTTP clients
 Mopidy is a music server which can play music both from multiple sources, like
 the local hard drive, radio streams, and from Spotify and SoundCloud.
 .
 Searches combines results from all music sources, and tracks can be mixed from
 all sources in the play queue. Spotify or SoundCloud playlists are
 also available for use.

Package: mopidy-doc
Section: doc
Architecture: all
Depends:
    ${misc:Depends},
    ${sphinxdoc:Depends}
Recommends: mopidy
Replaces: mopidy (<< 0.7.3-2)
Description: music server with support for MPD/HTTP clients - documentation
 Mopidy is a music server which can play music both from multiple sources, like
 the local hard drive, radio streams, and from Spotify and SoundCloud.
 .
 This package provides the documentation for Mopidy.

Attachment: signature.asc
Description: Digital signature


Reply to: