[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://horizon/{openstack-dashboard-apache.templates}



Please find, for review, the debconf templates and packages descriptions for the horizon source package.

This review will last from Sunday, June 02, 2013 to Wednesday, June 12, 2013.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- horizon.old/debian/openstack-dashboard-apache.templates	2013-05-19 10:48:44.714633171 +0300
+++ horizon/debian/openstack-dashboard-apache.templates	2013-06-02 19:53:35.279360001 +0300
@@ -11,13 +11,14 @@
 Type: boolean
 Default: false
 _Description: Activate Dashboard and disable default VirtualHost?
- In Debian, Apache comes with a default website and a default page, configured
- in /etc/apache2/sites-available/default. Select if this configuration should be
- disabled and replaced by the Openstack Dashboard configuration.
+ The Apache package sets up a default web site and a default page, configured
+ in /etc/apache2/sites-available/default. 
+ .
+ Please choose this option to replace it by the Openstack Dashboard configuration.

Drop branding ("Debian") so that derived distros benefit from the same template.
 
Split in two paragraphs just like we usually do in such situations.

 Template: horizon/use_ssl
 Type: boolean
 Default: true
 _Description: Should the Dashboard be installed on HTTPS?
- Please choose if you would like Horizon to be installed on HTTPS only, with a
+ Please select this option if you would like Horizon to be installed on HTTPS only, with a
  redirection to HTTPS if HTTP is in use.

Ou standard wording.

I'm not fond of "installed on HTTPS". That sounds a bit Frenglish to
me...:-). Even in French, indeed, the website is not installed "sur
HTTPS". 

Justin?

-- 


# These templates have been reviewed by the debian-l10n-english
# team
#
# If modifications/additions/rewording are needed, please ask
# debian-l10n-english@lists.debian.org for advice.
#
# Even minor modifications require translation updates and such
# changes should be coordinated with translators and reviewers.

Template: horizon/activate_vhost
Type: boolean
Default: false
_Description: Activate Dashboard and disable default VirtualHost?
 The Apache package sets up a default web site and a default page, configured
 in /etc/apache2/sites-available/default. 
 .
 Please choose this option to replace it by the Openstack Dashboard configuration.

Template: horizon/use_ssl
Type: boolean
Default: true
_Description: Should the Dashboard be installed on HTTPS?
 Please select this option if you would like Horizon to be installed on HTTPS only, with a
 redirection to HTTPS if HTTP is in use.
--- horizon.old/debian/openstack-dashboard-apache.templates	2013-05-19 10:48:44.714633171 +0300
+++ horizon/debian/openstack-dashboard-apache.templates	2013-06-02 19:53:35.279360001 +0300
@@ -11,13 +11,14 @@
 Type: boolean
 Default: false
 _Description: Activate Dashboard and disable default VirtualHost?
- In Debian, Apache comes with a default website and a default page, configured
- in /etc/apache2/sites-available/default. Select if this configuration should be
- disabled and replaced by the Openstack Dashboard configuration.
+ The Apache package sets up a default web site and a default page, configured
+ in /etc/apache2/sites-available/default. 
+ .
+ Please choose this option to replace it by the Openstack Dashboard configuration.
 
 Template: horizon/use_ssl
 Type: boolean
 Default: true
 _Description: Should the Dashboard be installed on HTTPS?
- Please choose if you would like Horizon to be installed on HTTPS only, with a
+ Please select this option if you would like Horizon to be installed on HTTPS only, with a
  redirection to HTTPS if HTTP is in use.
Source: horizon
Section: net
Priority: extra
Maintainer: PKG OpenStack <openstack-devel@lists.alioth.debian.org>
Uploaders: Loic Dachary (OuoU) <loic@debian.org>,
           Julien Danjou <acid@debian.org>,
           Thomas Goirand <zigo@debian.org>,
           Ghe Rivero <ghe.rivero@stackops.com>,
           Mehdi Abaakouk <sileht@sileht.net>
Build-Depends: debhelper (>= 9),
 po-debconf,
 python-all (>= 2.6.6-3~),
 python-setuptools
Build-Depends-Indep: openstack-pkg-tools,
 pep8 (>= 1.3.3),
 python-cloudfiles,
 python-compressor,
 python-coverage,
 python-django-nose,
 python-docutils,
 python-glanceclient,
 python-cinderclient,
 python-keystoneclient,
 python-mox,
 python-netaddr,
 python-nose,
 python-nosexcover,
 python-novaclient (>= 2:2.10),
 python-openstack-auth,
 python-quantumclient (>= 1:2.0),
 python-sphinx,
 python-swiftclient,
 python-tz,
 pylint,
 nodejs-legacy, 
 node-less
Standards-Version: 3.9.3
Homepage: http://horizon.openstack.org
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=openstack/horizon.git;a=summary
Vcs-Git: git://anonscm.debian.org/openstack/horizon.git

Package: python-django-horizon
Section: python
Architecture: all
Pre-Depends: dpkg (>= 1.15.6~)
Depends: ${misc:Depends}, ${python:Depends},
 python-cinderclient,
 python-cloudfiles,
 python-compressor,
 python-django,
 python-django-nose,
 python-glanceclient,
 python-keystoneclient,
 python-lockfile,
 python-memcache,
 python-netaddr,
 python-novaclient (>= 2:2.10),
 python-openstack-auth,
 python-quantumclient (>= 1:2.0),
 python-swiftclient,
 python-tz,
Recommends: memcached
Description: Django module providing web interaction with OpenStack
 The OpenStack Dashboard is a Web application allowing to control an OpenStack
 cloud. It connects to OpenStack services including Nova, Swift, Keystone, etc.
 using the Openstack REST API just like you would do with the command line
 clients.
 .
 Horizon is a Django module that permits interaction with an OpenStack
 cloud. It can be used to build a dashboard to control an OpenStack cloud.

Package: openstack-dashboard
Architecture: all
Pre-Depends: dpkg (>= 1.15.6~)
Depends: ${shlibs:Depends},
 ${misc:Depends},
 ${python:Depends},
 python-django-horizon (= ${source:Version}),
 libjs-jquery,
 libjs-jquery-cookie,
 node-less,
 adduser,
 libapache2-mod-wsgi (>= 2.3)
Recommends: memcached, openstack-dashboard-apache
Description: OpenStack Dashboard
 The OpenStack Dashboard is a Web application allowing to control an OpenStack
 cloud. It connects to OpenStack services including Nova, Swift, Keystone, etc.
 using the Openstack REST API just like you would do with the command line
 clients.

Package: openstack-dashboard-apache
Architecture: all
Pre-Depends: dpkg (>= 1.15.6~)
Depends: debconf,
 openstack-dashboard,
 ${misc:Depends}
Description: OpenStack Dashboard - Apache support
 The OpenStack Dashboard is a Web application allowing to control an OpenStack
 cloud. It connects to OpenStack services including Nova, Swift, Keystone, etc.
 using the Openstack REST API just like you would do with the command line
 clients.
 .
 This package includes the configuration files to use within Apache. If you
 wish to configure Apache yourself, use only openstack-dashboard.

Attachment: signature.asc
Description: Digital signature


Reply to: