[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://ntfs-3g/{ntfs-3g.templates}



Please find, for review, the debconf templates and packages descriptions for the ntfs-3g source package.

This review will last from Saturday, May 28, 2011 to Tuesday, June 07, 2011.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ntfs-3g.old/debian/ntfs-3g.templates	2011-05-22 12:00:44.195872156 +0200
+++ ntfs-3g/debian/ntfs-3g.templates	2011-05-28 08:09:17.355060949 +0200
@@ -1,9 +1,9 @@
 Template: ntfs-3g/setuid-root
 Type: boolean
 Default: false
-_Description: Should NTFS-3G be installed 'setuid root'?
+_Description: Should NTFS-3G be installed "setuid root"?
  NTFS-3G can be installed with the set-user-id bit set, so that it will run
- with the permissions of the 'root' user. This allows ordinary user to
+ with the permissions of the "root" user. This allows unprivileged users to
  mount NTFS volumes.
  .
  Enabling this feature may be a security risk, so it is disabled by

Standardize on double quotes as we're doing in all reviews.


--- ntfs-3g.old/debian/control	2011-05-22 12:00:44.199872184 +0200
+++ ntfs-3g/debian/control	2011-05-23 07:48:51.198916534 +0200
@@ -11,7 +11,7 @@
 Architecture: any
 Pre-Depends: fuse-utils
 Depends: ${misc:Depends}, ${shlibs:Depends}
-Description: read-write NTFS driver for FUSE
+Description: read-write NTFS driver for FUSE - binaries
  NTFS-3G is an NTFS driver for FUSE. It can create, remove, rename, move files,
  directories, hard links, and streams; it can read and write files,
  includingstreams, sparse files and transparently compressed files; it can

As other packages use a "general - specific"-style synopsis, let's use
one for this package too

@@ -26,7 +26,7 @@
 Depends:
  ${misc:Depends}, ntfs-3g (= ${binary:Version}),
  libntfs-3g804 (= ${binary:Version}), libntfs-3g-dev (= ${binary:Version})
-Description: read-write NTFS driver for FUSE (debug)
+Description: read-write NTFS driver for FUSE - debug package
  NTFS-3G is an NTFS driver for FUSE. It can create, remove, rename, move files,
  directories, hard links, and streams; it can read and write files,
  includingstreams, sparse files and transparently compressed files; it can

Standardize on "general - specific" instead of "general
(specific)"....this is just a matter of overall consistency among apckages.


@@ -34,13 +34,13 @@
  provides standard management of file ownership and permissions, including POSIX
  ACLs.
  .
- This package contains the debugging symbols.
+ This package provides the debugging symbols.

We usually recommend "provides". That's mostly cosmetic..:-)

No other changes suggested, though I would indeed wonder if FUSE should
be explained. Maybe it should...


Template: ntfs-3g/setuid-root
Type: boolean
Default: false
_Description: Should NTFS-3G be installed "setuid root"?
 NTFS-3G can be installed with the set-user-id bit set, so that it will run
 with the permissions of the "root" user. This allows unprivileged users to
 mount NTFS volumes.
 .
 Enabling this feature may be a security risk, so it is disabled by
 default. If in doubt, you should leave it disabled.
--- ntfs-3g.old/debian/ntfs-3g.templates	2011-05-22 12:00:44.195872156 +0200
+++ ntfs-3g/debian/ntfs-3g.templates	2011-05-28 08:09:17.355060949 +0200
@@ -1,9 +1,9 @@
 Template: ntfs-3g/setuid-root
 Type: boolean
 Default: false
-_Description: Should NTFS-3G be installed 'setuid root'?
+_Description: Should NTFS-3G be installed "setuid root"?
  NTFS-3G can be installed with the set-user-id bit set, so that it will run
- with the permissions of the 'root' user. This allows ordinary user to
+ with the permissions of the "root" user. This allows unprivileged users to
  mount NTFS volumes.
  .
  Enabling this feature may be a security risk, so it is disabled by
--- ntfs-3g.old/debian/control	2011-05-22 12:00:44.199872184 +0200
+++ ntfs-3g/debian/control	2011-05-23 07:48:51.198916534 +0200
@@ -11,7 +11,7 @@
 Architecture: any
 Pre-Depends: fuse-utils
 Depends: ${misc:Depends}, ${shlibs:Depends}
-Description: read-write NTFS driver for FUSE
+Description: read-write NTFS driver for FUSE - binaries
  NTFS-3G is an NTFS driver for FUSE. It can create, remove, rename, move files,
  directories, hard links, and streams; it can read and write files,
  includingstreams, sparse files and transparently compressed files; it can
@@ -26,7 +26,7 @@
 Depends:
  ${misc:Depends}, ntfs-3g (= ${binary:Version}),
  libntfs-3g804 (= ${binary:Version}), libntfs-3g-dev (= ${binary:Version})
-Description: read-write NTFS driver for FUSE (debug)
+Description: read-write NTFS driver for FUSE - debug package
  NTFS-3G is an NTFS driver for FUSE. It can create, remove, rename, move files,
  directories, hard links, and streams; it can read and write files,
  includingstreams, sparse files and transparently compressed files; it can
@@ -34,13 +34,13 @@
  provides standard management of file ownership and permissions, including POSIX
  ACLs.
  .
- This package contains the debugging symbols.
+ This package provides the debugging symbols.
 
 Package: libntfs-3g804
 Section: libs
 Architecture: any
 Depends: ${misc:Depends}, ${shlibs:Depends}
-Description: read-write NTFS driver for FUSE (library)
+Description: read-write NTFS driver for FUSE - shared library
  NTFS-3G is an NTFS driver for FUSE. It can create, remove, rename, move files,
  directories, hard links, and streams; it can read and write files,
  includingstreams, sparse files and transparently compressed files; it can
@@ -48,13 +48,13 @@
  provides standard management of file ownership and permissions, including POSIX
  ACLs.
  .
- This package contains the shared library.
+ This package provides the shared library.
 
 Package: libntfs-3g-dev
 Section: libdevel
 Architecture: any
 Depends: ${misc:Depends}, libntfs-3g804 (= ${binary:Version})
-Description: read-write NTFS driver for FUSE (library development)
+Description: read-write NTFS driver for FUSE - development files
  NTFS-3G is an NTFS driver for FUSE. It can create, remove, rename, move files,
  directories, hard links, and streams; it can read and write files,
  includingstreams, sparse files and transparently compressed files; it can
@@ -62,4 +62,4 @@
  provides standard management of file ownership and permissions, including POSIX
  ACLs.
  .
- This package contains the development files for the shared library.
+ This package provides the development files for the shared library.
Source: ntfs-3g
Section: otherosfs
Priority: optional
Maintainer: Daniel Baumann <daniel.baumann@progress-technologies.net>
Build-Depends: debhelper (>= 8), autotools-dev, chrpath, libfuse-dev, pkg-config
Standards-Version: 3.9.2
Homepage: http://www.tuxera.com/community/ntfs-3g-advanced/

Package: ntfs-3g
Section: otherosfs
Architecture: any
Pre-Depends: fuse-utils
Depends: ${misc:Depends}, ${shlibs:Depends}
Description: read-write NTFS driver for FUSE - binaries
 NTFS-3G is an NTFS driver for FUSE. It can create, remove, rename, move files,
 directories, hard links, and streams; it can read and write files,
 includingstreams, sparse files and transparently compressed files; it can
 handle special files like symbolic links, devices, and FIFOs; moreover it
 provides standard management of file ownership and permissions, including POSIX
 ACLs.

Package: ntfs-3g-dbg
Section: debug
Priority: extra
Architecture: any
Depends:
 ${misc:Depends}, ntfs-3g (= ${binary:Version}),
 libntfs-3g804 (= ${binary:Version}), libntfs-3g-dev (= ${binary:Version})
Description: read-write NTFS driver for FUSE - debug package
 NTFS-3G is an NTFS driver for FUSE. It can create, remove, rename, move files,
 directories, hard links, and streams; it can read and write files,
 includingstreams, sparse files and transparently compressed files; it can
 handle special files like symbolic links, devices, and FIFOs; moreover it
 provides standard management of file ownership and permissions, including POSIX
 ACLs.
 .
 This package provides the debugging symbols.

Package: libntfs-3g804
Section: libs
Architecture: any
Depends: ${misc:Depends}, ${shlibs:Depends}
Description: read-write NTFS driver for FUSE - shared library
 NTFS-3G is an NTFS driver for FUSE. It can create, remove, rename, move files,
 directories, hard links, and streams; it can read and write files,
 includingstreams, sparse files and transparently compressed files; it can
 handle special files like symbolic links, devices, and FIFOs; moreover it
 provides standard management of file ownership and permissions, including POSIX
 ACLs.
 .
 This package provides the shared library.

Package: libntfs-3g-dev
Section: libdevel
Architecture: any
Depends: ${misc:Depends}, libntfs-3g804 (= ${binary:Version})
Description: read-write NTFS driver for FUSE - development files
 NTFS-3G is an NTFS driver for FUSE. It can create, remove, rename, move files,
 directories, hard links, and streams; it can read and write files,
 includingstreams, sparse files and transparently compressed files; it can
 handle special files like symbolic links, devices, and FIFOs; moreover it
 provides standard management of file ownership and permissions, including POSIX
 ACLs.
 .
 This package provides the development files for the shared library.

Attachment: signature.asc
Description: Digital signature


Reply to: