Le 17/06/2010 01:12, Christian PERRIER a écrit :
> This is the last call for comments for the review of debconf
> templates for chef.
Please find attach two type of correction, and at the end of this
message a question about one of the templates.
*A pair of cosmetic changes and typos*
> -_Description: Temporary password for the Chef server user "admin":
> +_Description: Temporary password for the Chef server user "admin":
(Lots of trailing spaces deleted)
> -_Description: Password for the AMQP user "chef" in the RabbitMQ vhost "/chef":
> +_Description: Password for the AMQP user "chef":
(Attempt to keep the short description "short": everything needed is
explained in the long description, in a better way)
> -Description: Chef server URL:
> +_Description: Chef server URL:
(Make the field translatable)
*Some debconf abuse shrink* ("Keep usage notes to what they belong: the
NEWS.Debian, or README.Debian file." [0])
Stuff like:
> - .
> - This value will be stored in /etc/chef/client.rb as "chef_server_url".
have not their place in a debconf screen, administrator who need to
perform some configuration without using debconf are welcome to find
some more accurate information in README.Debian (you may want to add
something about passwords in README.Debian, I didn't find information
after a quick look).
[0]http://www.debian.org/doc/developers-reference/best-pkging-practices.html#s6.5.1
I also wonder what is the purpose of this one, maybe chef maintainers
will be able to enlighten us. If not, I'll try to USTL in order to try
and understand it tomorrow:
> RabbitMQ's rabbitmqctl program, which will be used to set this password,
> cannot read input from a file. Instead it will be passed as a command-line
> argument, so the password should not include any shell meta-characters
> that could cause errors, such as "!".
If the limitation is only due to the way the password is set up during
the package setup, this really sound like an issue that should be
addressed on the postinst script in order to let the user choose the
password he wants. If the limitation is due to how the user connect
himself to the AMQP (or RabbitMQ, I haven't understood it yet), we'll
probably need to rephrase this template.
Cheers
David
diff -ur ../../orig/chef-0.8.16/debian//chef-server-webui.templates ./chef-server-webui.templates --- ../../orig/chef-0.8.16/debian//chef-server-webui.templates 2010-06-17 10:05:03.000000000 -0400 +++ ./chef-server-webui.templates 2010-06-17 09:59:26.000000000 -0400 @@ -1,6 +1,6 @@ Template: chef-server-webui/admin_password Type: password -_Description: Temporary password for the Chef server user "admin": +_Description: Temporary password for the Chef server user "admin": Please choose a temporary password for the first time the "admin" user logs into the Chef server web interface. It should be changed immediately after being used. @@ -8,6 +8,3 @@ This password must be at least six characters long. If no password is entered, a default value will be used which is displayed on the Chef server web interface home page. - . - The password will be stored in /etc/chef/webui.rb as the value of - "web_ui_admin_default_password". diff -ur ../../orig/chef-0.8.16/debian//chef-solr.templates ./chef-solr.templates --- ../../orig/chef-0.8.16/debian//chef-solr.templates 2010-06-17 10:05:04.000000000 -0400 +++ ./chef-solr.templates 2010-06-17 10:01:05.000000000 -0400 @@ -1,6 +1,6 @@ Template: chef-solr/amqp_password Type: password -_Description: Password for the AMQP user "chef" in the RabbitMQ vhost "/chef": +_Description: Password for the AMQP user "chef": Please choose a password for the default user (named "chef") in the AMQP server queue, under the default RabbitMQ vhost (also "/chef"). . @@ -8,6 +8,3 @@ cannot read input from a file. Instead it will be passed as a command-line argument, so the password should not include any shell meta-characters that could cause errors, such as "!". - . - This value will be stored in /etc/chef/solr.rb and /etc/chef/server.rb as - "amqp_pass". diff -ur ../../orig/chef-0.8.16/debian//chef.templates ./chef.templates --- ../../orig/chef-0.8.16/debian//chef.templates 2010-06-17 10:05:00.000000000 -0400 +++ ./chef.templates 2010-06-17 09:58:13.000000000 -0400 @@ -1,7 +1,5 @@ Template: chef/chef_server_url Type: string -Description: Chef server URL: +_Description: Chef server URL: Please specify the full URL that clients will use to connect to the Chef server (for instance "http://chef.example.com:4000";). - . - This value will be stored in /etc/chef/client.rb as "chef_server_url".
Attachment:
signature.asc
Description: OpenPGP digital signature