Re: [RFR] templates://glide/{libglide2.templates,libglide3.templates}
Hi!
Sorry to reply this late, have been a bit swamped lately. And thanks
for the review.
On Mon, 2009-03-30 at 07:20:13 +0200, Christian Perrier wrote:
> Rationale:
> --- glide.old/debian/libglide2.templates 2009-02-14 12:18:12.951869029 +0100
> +++ glide/debian/libglide2.templates 2009-03-24 07:26:04.664963077 +0100
> - If you do not have a card based on one of the listed chipsets, and you are
> - not compiling programs against glide, you should not have this package
> - installed.
> - .
> - If you do have a card based on one of the listed chipsets please file a
> - bug on this package, including the output from the command 'lspci -vm' in
> - the bug report.
> + If the graphical card in this computer does not use one of these
> + chipsets, and you are not compiling programs against glide,
> + this package will be useless.
> + .
> + If the graphical card is based on one of these chipsets, you
> + should report a bug against this package, including the output from the
> + "lspci -vm" command.
> .
> - Would you like to manually select the driver to use for now? (If not, a
> - default sane value for compiling against will be selected.)
> + Please choose whether you want to manually select the driver to use for now.
Why the switch from "please" to "should"?
Why the switch from single quotes to double quotes for the lspci command?
> Turn "you should not have this package" into "this package becomes
> useless". After all, I do what I want and I'm perfectly entitled to
> have a package that's useless..:-)
I'd prefer something like "this pakages becomes not useful", instead
of "useless", the latter seems pretty strong. :)
> Turn "file a bug" into "report a bug".
Or "file a bug report"?
> Template: libglide2/driver
> Type: select
> Choices: cvg, h3
> Default: ${default}
> -_Description: Please select a driver.
> - Please select the driver you would like to use.
> - .
> - cvg - Voodoo 2.
> - h3 - Voodoo Banshee and Voodoo 3.
> +_Description: Driver for 3D acceleration:
> + Please select the driver you would like to use for 3D acceleration:
> + - cvg: Voodoo 2;
> + - h3 : Voodoo Banshee and Voodoo 3.
> Use recommended itemization style and do not make it a separate paragraph.
Please use '*'. I've always got the impression that was the most used
itemization style in Debian, the recent numbers posted on debian-devel
confirms that, and I'm guessing the Smith project in a way might have
slightly turned the balance on those numbers.
> Package: libglide2
> @@ -29,15 +29,15 @@
> Description: graphics library for 3Dfx Voodoo based cards - shared libraries
> This package allows you to use the 3D functions of cards based on
> 3dfx Interactive, Inc's Voodoo 2 chipsets. You should install it if
> - you have such a card.
> + you use such a card.
> .
> - Note, this is NOT the package you want for Voodoo Banshee, Voodoo 3,
> - Voodoo 4, or Voodoo 5.
> + This package is not useful with Voodoo Banshee, Voodoo 3,
> + Voodoo 4, or Voodoo 5 cards.
> .
> - Also note that for the moment the original Voodoo Graphics chipset
> + Additionnally, the original Voodoo Graphics chipset
> is no longer supported.
> .
> - NOTE: You'll need the /dev/3dfx kernel driver to use this library.
> + You'll need the /dev/3dfx kernel driver to use this library.
>
> Do not yell..:-). Instead of "not the package you want", just use "not
> useful". Again, I could want a package even if it's useless...
Same comment as the previous "useless" one.
> We generally recommend dropping "NOTE:" stuff.
Why? I don't have a strong feeling about it, but it seems to make it
easier to visually mark this kind of out-of-band dependency information.
regards,
guillem
Reply to: