Bug#1067829: nfs-utils: FTBFS on arm{el,hf}: export-cache.c:110:51: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘time_t’ {aka ‘long long int’} [-Werror=format=]
Control: tags -1 + patch
Hi,
On 2024-03-27 11:02, Sebastian Ramacher wrote:
> export-cache.c: In function ‘junction_flush_exports_cache’:
> export-cache.c:110:51: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘time_t’ {aka ‘long long int’} [-Werror=format=]
> 110 | snprintf(flushtime, sizeof(flushtime), "%ld\n", now);
> | ~~^ ~~~
> | | |
> | | time_t {aka long long int}
> | long int
> | %lld
The attached patch by Vladimir Petko was sent upstream and fixes the
FTBFS on armhf/armel.
Emanuele
diff -Nru nfs-utils-2.6.4/debian/changelog nfs-utils-2.6.4/debian/changelog
--- nfs-utils-2.6.4/debian/changelog 2023-12-03 14:58:30.000000000 +0100
+++ nfs-utils-2.6.4/debian/changelog 2024-03-28 16:56:19.000000000 +0100
@@ -1,3 +1,10 @@
+nfs-utils (1:2.6.4-3.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Apply upstream patch to fix FTBFS on armhf/armel (Closes: #1067829)
+
+ -- Emanuele Rocca <ema@debian.org> Thu, 28 Mar 2024 16:56:19 +0100
+
nfs-utils (1:2.6.4-3) unstable; urgency=medium
[ Salvatore Bonaccorso ]
diff -Nru nfs-utils-2.6.4/debian/patches/flushtime-long-long-int.patch nfs-utils-2.6.4/debian/patches/flushtime-long-long-int.patch
--- nfs-utils-2.6.4/debian/patches/flushtime-long-long-int.patch 1970-01-01 01:00:00.000000000 +0100
+++ nfs-utils-2.6.4/debian/patches/flushtime-long-long-int.patch 2024-03-28 16:56:19.000000000 +0100
@@ -0,0 +1,17 @@
+Author: Vladimir Petko
+Origin: https://bugzilla.kernel.org/show_bug.cgi?id=218540
+Bug-Debian: https://bugs.debian.org/1067829
+
+Index: nfs-utils-2.6.4/support/junction/export-cache.c
+===================================================================
+--- nfs-utils-2.6.4.orig/support/junction/export-cache.c
++++ nfs-utils-2.6.4/support/junction/export-cache.c
+@@ -107,7 +107,7 @@ junction_flush_exports_cache(void)
+ xlog(D_GENERAL, "%s: time(3) failed", __func__);
+ return FEDFS_ERR_SVRFAULT;
+ }
+- snprintf(flushtime, sizeof(flushtime), "%ld\n", now);
++ snprintf(flushtime, sizeof(flushtime), "%lld\n", now);
+
+ for (i = 0; junction_proc_files[i] != NULL; i++) {
+ retval = junction_write_time(junction_proc_files[i], flushtime);
diff -Nru nfs-utils-2.6.4/debian/patches/series nfs-utils-2.6.4/debian/patches/series
--- nfs-utils-2.6.4/debian/patches/series 2023-12-03 14:58:30.000000000 +0100
+++ nfs-utils-2.6.4/debian/patches/series 2024-03-28 16:56:19.000000000 +0100
@@ -1,3 +1,4 @@
multiarch-kerberos-paths.patch
always-run-generator.patch
fsidd-call-anonymous-sockets-by-their-name-only-don-.patch
+flushtime-long-long-int.patch
Reply to: