[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#865691: marked as done (Unexpanded 'alias' caused failure of root fs type detection)

Your message dated Thu, 19 Jul 2018 00:19:36 +0000
with message-id <E1ffwfQ-000BTK-RO@fasolo.debian.org>
and subject line Bug#865691: fixed in initramfs-tools 0.131
has caused the Debian Bug report #865691,
regarding Unexpanded 'alias' caused failure of root fs type detection
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
865691: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=865691
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: initramfs-tools-core
Version: 0.130

On a machine recently upgraded to stretch, I found that
'update-initramfs -u' produced the following output:

> update-initramfs: Generating /boot/initrd.img-4.9.0-3-686
> Warning: couldn't identify filesystem type for fsck hook, ignoring.

and on a reboot, the machine's root filesystem was still mounted RO.

Re-running pieces of the filesystem type detection code manually, in an
instance of sh running under strace, suggested that the problem is in
the shell function get_fsck_type_fstab() in
/usr/share/initramfs-tools/hooks/fsck, which does this:

                      alias fstype="/usr/lib/klibc/bin/fstype"
                      get_fstype "${MNT_FSNAME}"
                      unalias fstype

But in spite of that, when get_fstype() executes

        eval $(fstype "${FS}" 2> /dev/null)

strace shows that the shell is searching $PATH for 'fstype' and not
finding it. In other words, the alias is being ignored - which isn't
surprising, since commands executed from inside a shell function are
indeed not subject to alias expansion.

Replacing the alias and unalias with a shell function definition and an
'unset -f' solved the problem for me: now update-initramfs doesn't print
that warning message, and my system boots with its root fs writable as I
expect.

I attach the patch I've applied on my system, which solves the problem
for me.

Cheers,
Simon

-- 
for k in [pow(x,37,0x1a1298d262b49c895d47f) for x in [0x50deb914257022de7fff,
0x213558f2215127d5a2d1, 0x90c99e86d08b91218630, 0x109f3d0cfbf640c0beee7,
0xc83e01379a5fbec5fdd1, 0x19d3d70a8d567e388600e, 0x534e2f6e8a4a33155123]]:
 print "".join([chr(32+3*((k>>x)&1))for x in range(79)]) # <anakin@pobox.com>

Attachment: initramfs-tools.diff
Description: Binary data


--- End Message ---
--- Begin Message --- 
Source: initramfs-tools
Source-Version: 0.131

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 865691@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ben Hutchings <ben@decadent.org.uk> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 19 Jul 2018 01:06:01 +0100
Source: initramfs-tools
Binary: initramfs-tools initramfs-tools-core
Architecture: source
Version: 0.131
Distribution: unstable
Urgency: medium
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Ben Hutchings <ben@decadent.org.uk>
Description:
 initramfs-tools - generic modular initramfs generator (automation)
 initramfs-tools-core - generic modular initramfs generator (core tools)
Closes: 845034 856589 856929 862013 865691 866521 871595 878829 880584 882380 883664 883735 886349 886424 887211 893845
Changes:
 initramfs-tools (0.131) unstable; urgency=medium
 .
   [ Ben Hutchings ]
   * [34bf250] debian/control: Remove maximilian attems and Adam Conrad from
     Uploaders field
   * [5ad3976] hooks/resume: Generalise logic to replace dev name with UUID when
     RESUME=auto
   * [0170b7f] hooks/resume: Store /dev/mapper path for swap if possible when
     RESUMEauto (Closes: #883735)
   * [5bf4c29] debian/control: Point Vcs URLs to Salsa
   * [e8377b3] hooks/fsck: Fix invocation of fstype at build time.
     Thanks to Simon Tatham <anakin@pobox.com> (Closes: #865691)
   * [492763a] docs: Convert maintainer notes to Markdown format
   * [0214976] docs/maintainer-notes.md: Update references to Alioth, to Salsa
   * [b71c6c9] docs/maintainer-notes.md: Delete mention of git-core package
   * [89daebf] docs/maintainer-notes.md: Change BTS link to specify source
     package
   * [8e539dc] docs/maintainer-notes.md: Link to tracker.debian.org instead of
     PTS
   * [3f27197] docs/maintainer-notes.md: Remove stale link to Debian bug count
     graph
   * [7dece27] docs/maintainer-notes.md: Use HTTP-S for Debian wiki and popcon
     links
   * [838b6ec] docs/maintainer-notes.md: Link directly to Ubuntu bug list
   * [eaa61d4] docs/maintainer-notes.md: Add myself as co-author
   * [fa7df8f] hook-functions: Correct the comment above hidden_dep_add_modules
   * [0ffbeb9] hook-functions: Remove directory information from
     hidden_dep_add_modules
   * [78e95c1] hook-functions: Check modules.builtin in hidden_dep_add_modules
   * [976aeb9] hook-functions: Handle i8042 hidden dependency on psmouse
     (Closes: #878829)
   * [211e050] hook-functions: Handle nvme hidden dependency on vmd.
     Thanks to Mario Limonciello <Mario.Limonciello@dell.com> (Closes: #886349)
   * [28536f6] unmkinitramfs, lsinitramfs: Split multiple early initramfs
     sections (Closes: #886424)
   * [2a9d97d] debian/control: Add e2fsprogs to Depends for initramfs-tools-core
     (Closes: #887211)
   * [577c94e] initramfs.conf: Update documentation of the DEVICE variable
   * [f1cbe6f] mkinitramfs: Build reproducible images when SOURCE_DATE_EPOCH is
     set. Thanks to Chris Lamb <lamby@debian.org> (Closes: #845034)
   * [717e6bd] mkinitramfs: Exclude ldconfig auxiliary cache from initramfs
     image. Thanks to Kristian Klausen <klausenbusk@hotmail.com>
   * [8bddfe4] mkinitramfs(8): Remove description of nonexistent options
   * [ecd6ce2] mkinitramfs(8), hook-functions: Correct references to "ramdisk"
   * [63cec7b] docs: Move initramfs-tools man page to section 7
   * [562d86e] docs: Update man page header dates
   * [9bd960e] docs: Set man page header source and manual parameters correctly
   * [97cc7e7] docs: Don't package maintainer documentation in
     initramfs-tools-core
   * [4e19a6f] docs: Remove outdated "HACKING" documentation file
   * [6c02622] debian/control: Remove obsolete Breaks and Depends relations
   * [749751c] debian/control: Update Standards-Version to 4.1.5
     - Set Rules-Requires-Root: no
   * [db469f0] initramfs-tools: Override lintian warning "breaks-without-version
     upstart"
 .
   [ Riku Voipio ]
   * [72b6419] auto_add_modules: add mfd for MODULES==most (Closes: #880584)
 .
   [ Benjamin Drung ]
   * [7ca4d0d] Add mlx4 and mlx5 InfiniBand modules to hidden_dep_add_modules
     (Closes: #871595)
   * [df7d7e8] Add option to clear screen at the beginning (Closes: #856929)
   * [a33cb62] Fix indentation (spaces to tabs)
   * [3962c4f] Fix config directory in error message (Closes: #856589)
   * [be2b91c] Double quote to prevent globbing and word splitting
   * [ae339ff] Make size of /run configurable (Closes: #862013)
 .
   [ Steve Langasek ]
   * [c198331] Skip dmsetup resume devices if they are randomly encrypted.
 .
   [ Paul Menzel ]
   * [e28b865] mkinitramfs: Add LZ4 support (Closes: #893845)
   * [5091a5e] control: Remove suggestion of *lz4-tools*
 .
   [ Colin Watson ]
   * [b4804dd] Only sync the filesystem containing the initramfs
     (Closes: #882380) (LP: #1667512)
 .
   [ Karsten Merker ]
   * [281ad9a] Include the axp20x_usb_power module in the base modules list for
     MODULES=most (Closes: #866521)
 .
   [ Ivan Kozik ]
   * [54367c0] init: export DEVICE so that when configured, it is actually set
     in configure_networking (Closes: #883664)
Checksums-Sha1:
 395067443279e14a823c9f9dc21427ed8508f9bb 1755 initramfs-tools_0.131.dsc
 0baf15009aef379337114f4d2821a03bbb50dd03 87676 initramfs-tools_0.131.tar.xz
 ff07f9dae7e3fef062668b4afe834eae86f1a3d9 6160 initramfs-tools_0.131_source.buildinfo
Checksums-Sha256:
 ba0ec72bfa05b449f76064f75c0f2bc0dc573bbb75e24cb03ea6c4d916e35429 1755 initramfs-tools_0.131.dsc
 126ea8044b07e9953ecc881788fe67cc7951f9b857237288d0c4ae125d214f21 87676 initramfs-tools_0.131.tar.xz
 8262cb83d8be04d748b6a29141bb361839221e138e13668690e6e397cdb0fbff 6160 initramfs-tools_0.131_source.buildinfo
Files:
 1c4b81907fd0299d410a88bfb913ecc2 1755 utils optional initramfs-tools_0.131.dsc
 729c1645eaa7e2bdc1cc8ae9eef81b2a 87676 utils optional initramfs-tools_0.131.tar.xz
 2142a4b53fe3938fb685c37f659f0221 6160 utils optional initramfs-tools_0.131_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAltP1rMACgkQ57/I7JWG
EQkstw//YnGrERYbjmycnYc4trZ0j6fMeglupSG6hCaF9mXE9Xc7ofDVnqQ6fAuh
Dqgg0KBdbM5dR4yjXkgE/0eBLTWAk9YDoe8QqAeqne7NF953boLEuB0TtD2IR15k
hf9rDY1TFAlKT17RXsO5whJpXihR6OtHPmoe7nCWzKw9krjIiD3vjORoqts5Dwqu
zG2EKy738LYyEPknNi2r+GuZOod/UubgKpG8wxDPVlR2pzcVnK1cJfSrOo2z+JBw
U5P+vIlO2eq6bmi9uWS87OLlyRtvmMUunUJ9fN6+qrBbffvD36EbW1xXIXuCsPaf
DcZerKiWhU5CrO8k/f9QUTy1sCtWwqR0jfNzLKmygreuhp2XvGtmZAhs9GFW7RpH
TLzgE846sxw4M6H4I417IFRgWXFELfIGDfN3jxGmkgWMLX24HGwx3kRnNjZF2YDP
JIdieeJriwB6B1l0IPO0sVx3kkGZuggsyu472Gu02hJeX9IeoE0SuqCD6vZBF/RW
LWAakzmfYCdXukrYvEQqFNWLcHrxhreAP/BFBPTKJ5skRf9aebuvBX8JONE4Ap6Y
BZX+093Zg/DN/uv4WWiugT4eL5cqYwyQQWFbA860uHHrtKspBOO0GSnIpw+xF2W5
yrUEVgYSBLOHvXObKV0DvwltuCM3KDiVHyOAMqS6liS0fgpajJk=
=dU0O
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: