On Fri, 2017-01-27 at 16:02 +0200, riku.voipio@linaro.org wrote: > From: Riku Voipio <riku.voipio@linaro.org> > > If CONFIG_USB_GADGET is selected, enable all configfs functions as > modules and most popular legacy modules (ethernet and serial). > g_nokia left as armhf specific (Nokia N900 tradition) [...] > --- a/debian/config/armhf/config > +++ b/debian/config/armhf/config > @@ -1114,9 +1114,6 @@ CONFIG_USB_GADGET=m > ## > ## file: drivers/usb/gadget/legacy/Kconfig > ## > -CONFIG_USB_ETH=m > -CONFIG_USB_ETH_RNDIS=y > -CONFIG_USB_GADGETFS=m > CONFIG_USB_G_NOKIA=m > > ## > diff --git a/debian/config/config b/debian/config/config > index c744073f9..d6ec09462 100644 > --- a/debian/config/config > +++ b/debian/config/config [...] > +## > +## file: drivers/usb/gadget/legacy/Kconfig > +## > +CONFIG_USB_ETH=m > +CONFIG_USB_ETH_RNDIS=y > +CONFIG_USB_GADGETFS=m > +CONFIG_USB_FUNCTIONFS=m > +CONFIG_USB_FUNCTIONFS_ETH=y > +CONFIG_USB_FUNCTIONFS_RNDIS=y > +CONFIG_USB_FUNCTIONFS_GENERIC=y > +CONFIG_USB_G_SERIAL=m Sorry to mess you around, but I wonder now if it really makes sense to enable more of the legacy interface. If I understood correctly, the configfs interface provides all the same functionality and more, and userspace should be moving to use that. Perhaps we should: 1. Enable the configfs interface in the top-level config 2. Leave armhf with limited legacy configuration interface support for stretch (in case there are users that depend on it) 3. Disable the legacy interface post-stretch. What do you think of that? Ben. -- Ben Hutchings Design a system any fool can use, and only a fool will want to use it.
Attachment:
signature.asc
Description: This is a digitally signed message part