[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#793786: initramfs-tools: fix the broken netconsole feature in initramfs-tools



On Sun, 2016-01-10 at 16:20 +0900, Roger Shimizu wrote:
> Control: reopen -1
> 
> On Wed, Dec 9, 2015 at 12:39 PM, Ben Hutchings <ben@decadent.org.uk> wrote:
> > An initramfs built with MODULES=most (default) always includes
> > netconsole.ko (assuming it was enabled in the kernel configuration).
> > So
> > the netconsole parameter needs to work even if netconsole doesn't
> > appear in /conf/modules, and your v3 breaks that.  So I applied your
> > v2.  Thanks.
> 
> I find current v2 patch will sometimes fail because it load netconsole.ko before
> loading network driver.

So maybe we should run 'udevadm settle' before loading modules?

> I made some changes based on patch v3, can confirmed various scenarios,
> including "MODULES=most" you mentioned. So here's patch v4.
> (also in my github repo's netconsole branch:
> https://github.com/rogers0/initramfs-tools/tree/netconsole)
> 
> the fix already takes various cases into account:
> - MODULES=most (default) or MODULES={dep,list} (popular for embedded devices)
> - netconsole param may be inside conf/modules or come with bootloader's config
> 
> for "MODULES=most" case , netconsole.ko is included by default, so there's
> no need to list it in conf/modules, and netconsole param should be put into
> bootloader's config
> 
> for "MODULES={dep,list}" case, netconsole param can be either from
> conf/modules or bootloader, and the previous one is preferred if both are
> specified.
[...]

The kernel parameter should be preferred if both are specified.  (In
general, the most specific configuration source should take
precedence.)

Ben.

-- 
Ben Hutchings
Power corrupts.  Absolute power is kind of neat.
                           - John Lehman, Secretary of the US Navy 1981-1987

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: