[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51



On Wed, 19 Dec 2012 07:29:23 -0800, Alan Stern <stern@rowland.harvard.edu> wrote:
+       ohci_dbg(ohci, "marked as bad wakeup.\n");

I'd prefer the message to be something more like "enabled nVidia/SiS
wakeup quirk".

To me, the stupid end-user, both messages are useless. I don't know
that that means or implies. I would go with:

"Disabled OHCI wakeup (USB) due to faulty controller (no-wakeup.txt)"

and have a file named no-wakeup.txt under Documentation with this:

"
Users have reported OHCI misbehavior consisting on false wakeups right
after suspend to RAM on some OHCI controllers, particularly from nVIDIA
and SiS. For those controllers, wakeups has been disabled.

The system will not be able to wake up the system from suspend
to RAM from an OHCI (USB) device.

To see the list of affected controllers do:

grep -B 3 ohci_quirk_bad_wakeup linux-pm/drivers/usb/host/ohci-pci.c

Bug is tracked at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677472
"

--
Octavio.


Reply to: