On Thu, 2012-12-06 at 10:58 +0100, Rik Theys wrote: > Hi, > > On 12/01/2012 11:10 PM, Ben Hutchings wrote: > > On Fri, 2012-11-30 at 11:10 +0100, Rik Theys wrote: > > [...] > >> I cherry picked commits 5ef30ee53b187786e64bdc1f8109e39d17f2ce58 and > >> 5195d8e217a78697152d64fc09a16e063a022465 and tried to compile the > >> result, but it failed with the following error: > >> > >> kernel/auditsc.c:2189: error: conflicting types for ‘__audit_mq_open’ > >> include/linux/audit.h:477: note: previous declaration of > >> ‘__audit_mq_open’ was here > >> kernel/auditsc.c:2289: error: conflicting types for ‘__audit_ipc_set_perm’ > >> include/linux/audit.h:471: note: previous declaration of > >> ‘__audit_ipc_set_perm’ was here > >> > >> Any idea on how to determine which intermediate patches are also needed? > >> Or should I just try to modify commit > >> 5195d8e217a78697152d64fc09a16e063a022465 to make it apply? > > > > It is not too difficult to fix up the conflicts. But this is a fairly > > big change, so I think this bug should now be 'wontfix' for wheezy. > > Sorry we didn't get it fixed earlier. > > Sorry to hear that. Would a patch that simply increases the static > number of entries in the names array be an acceptable workaround? It > would decrease the change of hitting this bug. Perhaps; do you have any idea what the limit should be? We do need to consider that this costs 76 bytes per name per task for which auditing is enabled, and there are normally hundreds or thousands of tasks running, so extra names aren't cheap. Ben. -- Ben Hutchings Computers are not intelligent. They only think they are.
Attachment:
signature.asc
Description: This is a digitally signed message part