[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] scripts/package/builddeb: upgrade to current practices



On Wed, Jul 18, 2012 at 02:19:25AM +0300, Martin-Éric Racine wrote:
> 2012/7/18 maximilian attems <max@stro.at>:
> > On Tue, Jul 17, 2012 at 10:46:23PM +0300, Martin-Éric Racine wrote:
> >> 2012/7/17 Jonathan Nieder <jrnieder@gmail.com>:
> >> >>
> >> >>  Package: $fwpackagename
> >> >>  Architecture: all
> >> >> +Conflicts: firmware-linux-free, firmware-linux-nonfree
> >> >> +Provides: firmware-linux-free, firmware-linux-nonfree
> >> >> +Replaces: firmware-linux-free, firmware-linux-nonfree
> >> >
> >> > I assume you mean Breaks+Replaces.  Do the files actually overlap,
> >> > or is this change being overly cautious?  I would expect the files
> >> > not to overlap because the package build with deb-pkg puts firmware
> >> > in a versioned subdirectory "/lib/firmware/<version>".
> >>
> >> AFAIK they would overlap, hence the Conflicts.
> >
> > This is wrong and properly fixed in -next.
> 
> Exactly what is wrong with this fix? Could you tell us exactly what
> you did differently and why?

Jonathan already answered it, saying that firmwares are put
in versioned dir.

Just use git to look it up, easy:
~/src/linux-next (master %=)$ git log scripts/package/builddeb

6607ddadf93d19c7f64139f1475c342152f39fe5

Your conflict would mean to kick out the official debian firmware
packages which is not something we want!

-- 
maks


Reply to: