Bug#508527: [PATCH] via-velocity: Give RX descriptors to the NIC later on open or MTU change

[David Miller <davem@davemloft.net>]

From: Ben Hutchings <ben@decadent.org.uk>
Date: Tue, 15 Dec 2009 02:05:09 +0000

> velocity_open() calls velocity_give_many_rx_descs(), which gives RX
> descriptors to the NIC, before installing an interrupt handler or
> calling velocity_init_registers().  I think this is very unsafe and it
> appears to explain the bug report <http://bugs.debian.org/508527>.
> 
> On MTU change, velocity_give_many_rx_descs() is again called before
> velocity_init_registers().  I'm not sure whether this is unsafe but
> it does look wrong.
> 
> Therefore, move the calls to velocity_give_many_rx_descs() after
> request_irq() and velocity_init_registers().
> 
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> This is untested; I don't have this hardware.

Although this patch looks fine to me, I don't want to apply
it until someone tests it.