[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [jblache@debian.org: Re: [PATCH 2.6] Add back beep support to snd-powermac]



On Wed, Jun 23, 2004 at 01:22:49PM +0200, Jens Schmalzing wrote:
> Dear Sven,
> 
> > How about including this patch ? 
> 
> I'd say the author (Derrick? Julien?) should try to get it included
> upstream.  Beep is not a very high priority.
> 
> > BTW, i added both a new uhci fix
> 
> Ok.
> 
> > and the marvell driver to the svn repo,
> 
> It's *huge*.  Any reason why it should be powerpc-only?

Huge ? It is a full gigabit ethernet driver, what did you expect ? 

Well, it should be powerpc & mips only, since the discovery II only
supports those architectures, and the current version doesn't run on
mips, as it contains some powerpc only improvements. Not that i know
of any actual motherboard using the discovery II on mips yet anyway,
so ...

We will get this one included upstream, but it won't happen overnight,
it would be great if it could live in the powerpc patch until we do so.

> > as well as started the practice of marking the new changelog as
> > UNRELEASED, please change it back before making the build for the
> > next release.
> 
> Please don't do this, it's too easy to forget.

He. Well, ok, the idea behind it is to not upload a package by mistake
while it has not yet been blessed. And dupload/queue handler will detect
it or something, but as you wish.

> > Also, maybe we should start using the same convention as the
> > debian-installer packages is using, that is, have each changelog
> > entry marked by the person doing it :
> > 
> >   * Sven
> >     - Stuff 1
> >     - Stuff 2
> > 
> >   * Jens 
> >     - Stuff 3
> >     - Stuff 4
> > 
> > And so on ? 
> 
> This doesn't work well in emacs and is not chronological, I would
> prefer the way we did it for kernel-source:

well, all debian-installer stuff work like this, for example
yaboot-installer shows : 

   * Colin Watson
     - Support backing up.
   * Updated translations:
     - Finnish (fi.po) by Tapio Lehtonen
     - Hebrew (he.po) by Lior Kaplan
     - Portuguese (pt.po) by Miguel Figueiredo

You are supposed o use dch -a anyway to add a new entry, which would set
also the last modification entry correctly and such. But maybe we should
discuss this more broadely. Other collectively held packages like
XFree86 or gcc also do it this way.

>   * Stuff 1 (Sven Luther).
>   * Stuff 2 (Jens Schmalzing).
>   * Stuff 3 (Jens Schmalzing).
>   * Stuff 4 (Sven Luther).

Well I serisously doubt the order of stuff is of all that importance to
the the enduser of the changelog file, which see this stuff in debian
version increment only anyway. And if you really like to have the
chronological order, that's what subversion changelogs are all about,
don't they ? 

BTW, where you able to boot kernels whose image was generated with
version 3.1-pre2-1 of module-init-tools (the one in unstable) installed ? 
It fails here because of missing /etc/modprobe.conf.

Friendly,

Sven Luther



Reply to: