Re: SV: Bug#621834: marked as done (DDTP - accessibility problem, probably database corroption)

[Michael Bramer <m.bramer@deb-support.de>]

On 08/11/2011 09:36 AM, Christian PERRIER wrote:
> I silently changed this in early July in
> /org/ddtp.debian.net/ddtss/ddtss-setup on churro:
>
> # Set default values for all languages
> for my $lang (@langs)
> {
> # Minimum number of untranslated descriptions to have at any time
>    $db->put("$lang/config/minuntranslated", '1');
> # Number of reviewers before sending, can be zero
>    $db->put("$lang/config/numreviewers", '3');
> # Do we require translators to be registered?
>    $db->put("$lang/config/requirelogin", '1');
> }
>
> This was done on purpose, as a way to really see how anon
> contributions are done!

But after this code we have some 'Special value' for some languages...

> I voluntarily allowed anon contribs for German as we had a mention
> that an active contributor was working this way BUT I STILL THINK WE
> SHOULD DISABLE THAT ALSO (and I was indeed intending to disable it for
> German too later on).
>
> And, *now only*, someone notices..:)

If you don't start the script, your change was not commit to the 
database...

Now I start the script to adding 'sr' and this make your change active.

now we have this:
ddtp=> SELECT * from ddtss where key like '%requirelogin%';
            key            | value
---------------------------+-------
 pt_BR/config/requirelogin | 1
 ru/config/requirelogin    | 1
 sk/config/requirelogin    | 1
 sv/config/requirelogin    | 1
 uk/config/requirelogin    | 1
 vi/config/requirelogin    | 1
 zh_CN/config/requirelogin | 1
 zh_TW/config/requirelogin | 1
 id/config/requirelogin    | 1
 km_KH/config/requirelogin | 1
 pl/config/requirelogin    | 1
 sr/config/requirelogin    | 1
 ca/config/requirelogin    | 1
 cs/config/requirelogin    | 1
 da/config/requirelogin    | 1
 de/config/requirelogin    | 0
 eo/config/requirelogin    | 1
 es/config/requirelogin    | 1
 fi/config/requirelogin    | 1
 fr/config/requirelogin    | 1
 hu/config/requirelogin    | 1
 it/config/requirelogin    | 1
 ja/config/requirelogin    | 1
 ko/config/requirelogin    | 1
 ml/config/requirelogin    | 1
 nb/config/requirelogin    | 1
 nl/config/requirelogin    | 1
 pt/config/requirelogin    | 1

only german is allowing anon contribs...

If I check the database backup from 6.8:
zgrep requirelogin pg_dump/pg_ddts.dump.gz.1
ca/config/requirelogin  0
cs/config/requirelogin  0
da/config/requirelogin  0
de/config/requirelogin  0
eo/config/requirelogin  0
es/config/requirelogin  0
fi/config/requirelogin  0
fr/config/requirelogin  0
hu/config/requirelogin  0
id/config/requirelogin  0
it/config/requirelogin  0
ja/config/requirelogin  0
km_KH/config/requirelogin 0
ko/config/requirelogin  0
ml/config/requirelogin  0
nb/config/requirelogin  0
nl/config/requirelogin  0
pl/config/requirelogin  0
pt/config/requirelogin  0
pt_BR/config/requirelogin 0
ru/config/requirelogin  0
sk/config/requirelogin  0
sv/config/requirelogin  0
uk/config/requirelogin  0
vi/config/requirelogin  1
zh_CN/config/requirelogin 0
zh_TW/config/requirelogin 0

> Seems to me like a good proof that nearly nobody is seriously using
> anonymous contributions in the DDTSS. Maybe with one exception: Danish..:)

This proof is not right...

Your change in the script in early July, was activated by myself 
yesterday evening and confuse our translators/reviewer... (see Joe 
Dalton mail)

> So, my intent is to leave this as is. Of course, this is still
> configurable per-language, as Martijn designed this very
> well.

My intent is to leave this on the old values and change it on request.

Comments

Gruss
Grisu