[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Unofficial GNU/Hurd release (#636568)



On Thu, 2012-10-11 at 16:31 +0200, Pino Toscano wrote:
> Hi,
> 
> Alle giovedì 11 ottobre 2012, Svante Signell ha scritto:
> > > > -    if (!curDir)
> > > > +    if (curDir == NULL)
> > > 
> > > Why did you change this?
> > 
> > Dunno, changed!
> 
> Usually reading a patch before sending it would help, also with...

Well the version of the patch I first sent was created Aug 4, 2011.
After that I made the new changes.

> > -    return XMLString::transcode(curDir, manager);
> > +        XMLCh *ret = XMLString::transcode(curDir, manager);
> 
> .. this, which has an indentation change.

Modified.

> > A new patch attached. OK now?
> 
> With the above fixed, yes.

Thanks!



Reply to: