Re: dovecot: FTBFS on hurd-i386 (for review)

[Guillem Jover <guillem@debian.org>]

On Thu, 2012-08-30 at 14:07:18 +0200, Svante Signell wrote:
> Source: dovecot
> Version: 2.1.7-2
> Severity: important
> Tags: patch
> Usertags: hurd
> User: debian-hurd@lists.debian.org

> The number of entries of PATH_MAX are too many to make dynamic unless
> upstream is interested.

That's a pitty though.

> -- a/src/lib/lib.h     2011-12-13 12:35:29.000000000 +0100
> +++ b/src/lib/lib.h     2012-08-29 15:42:34.000000000 +0200
> @@ -14,6 +14,12 @@
>  #endif
>  #include <stdarg.h> /* va_list is used everywhere */
>  #include <limits.h> /* INT_MAX, etc. */
> +#if (!defined(PIPE_BUF) && defined(__USE_POSIX))
> +#define PIPE_BUF 8*_POSIX_PIPE_BUF
> +#endif
> +#if (!defined(PATH_MAX) && defined(__USE_POSIX))
> +#define PATH_MAX 16*_POSIX_PATH_MAX
> +#endif
>  #include <errno.h> /* error checking is good */
>  #include <sys/types.h> /* many other includes want this */

__USE_POSIX is an internal macro, and should not be used for feature
tests, you could as well just test if _POSIX_PIPE_BUF or
_POSIX_PATH_MAX are defined.

thanks,
guillem