Re: Bug#686103: libetpan: FTBFS on hurd-i386
On Tue, 2012-08-28 at 19:06 +0200, Philipp A. Hartmann wrote:
> On 28/08/12 18:20, Svante Signell wrote:
> > On Tue, 2012-08-28 at 18:14 +0200, Samuel Thibault wrote:
> >> Svante Signell, le Tue 28 Aug 2012 17:55:07 +0200, a écrit :
> >>> --- a/libetpan-config.h.in 2008-05-23 00:39:44.000000000 +0200
> >>> +++ b/libetpan-config.h.in 2012-08-28 17:36:00.000000000 +0200
> >>> @@ -15,6 +15,9 @@
> >>> #ifdef HAVE_LIMITS_H
> >>> @include <limits.h>
> >>> #endif
> >>> +#ifndef PATH_MAX
> >>> +@define PATH_MAX 4096
> >>
> >> Typo here.
> >
> > No, @ is expanded to # when libetpan-config.h is created:
> > cat ./libetpan-config.h.in | i486-gnu-gcc -E -I. - \
> > | sed -e '/^#/d;/^[ \t]*$/d;s/^@/#/' > libetpan-config.h
>
> AFAICS, this would require to have '@'s in all added lines, since all
> system includes are avoided by using the '@'. You would then end up
> with redefining PATH_MAX even on platforms where PATH_MAX is defined via
> the skipped limits.h:
>
> @ifndef PATH_MAX
> @define PATH_MAX 4096
> @endif
Yes, you are right. Adding this info to bug #686103, too.
Thanks!
Modified patch below:
--- a/libetpan-config.h.in 2008-05-23 00:39:44.000000000 +0200
+++ b/libetpan-config.h.in 2012-08-28 17:36:00.000000000 +0200
@@ -15,6 +15,9 @@
#ifdef HAVE_LIMITS_H
@include <limits.h>
#endif
+@ifndef PATH_MAX
+@define PATH_MAX 4096
+@endif
#ifdef HAVE_SYS_PARAM_H
/* support for ARM platforms with a 2.95.3 arm-gcc suite */
@include <sys/param.h>
--- a/tests/option-parser.c 2010-11-16 21:46:35.000000000 +0100
+++ b/tests/option-parser.c 2012-08-28 17:36:25.000000000 +0200
@@ -12,6 +12,9 @@
#include <stdlib.h>
#include <string.h>
#include <limits.h>
+#ifndef PATH_MAX
+#define PATH_MAX 4096
+#endif
#include <libetpan/libetpan.h>
Reply to: