Re: SiS900

[Thomas Schwinge <schwinge-debian-hurd@nic-nac-project.de>]

On Mon, Mar 28, 2005 at 12:47:09PM +0200, Andreas B. Mundt wrote:
> [ SiS900 driver ]

> exploring the code where the patch went wrong led to minor changes in 
> the eeprom (mac address-) reading function ...
> 
> In addition I removed some "printk"- debugging.

..., so you changed Linux's source files.

> diff -ruN gnumach.orig/linux/src/drivers/net/sis900.c 
> gnumach.sis900/linux/src/drivers/net/sis900.c
> --- gnumach.orig/linux/src/drivers/net/sis900.c	1970-01-01 
> 01:00:00.000000000 +0100
> +++ gnumach.sis900/linux/src/drivers/net/sis900.c	2005-03-27 
> 20:52:47.000000000 +0200

> diff -ruN gnumach.orig/linux/src/drivers/net/sis900.h 
> gnumach.sis900/linux/src/drivers/net/sis900.h
> --- gnumach.orig/linux/src/drivers/net/sis900.h	1970-01-01 
> 01:00:00.000000000 +0100
> +++ gnumach.sis900/linux/src/drivers/net/sis900.h	2005-03-26 
> 21:08:35.000000000 +0100

You should put Linux's original files (i.e. the versions your patch is
based on) into linux/src/ and put your modified files into linux/dev/.
The files from linux/dev/ will shadow the linux/src/ ones.
Doing so, one can easily see the changes you had to do and, thus, can
more easily maintain / update the driver (when a new Linux version is
available, etc.).


Regards,
 Thomas