Re: Bug#295117: libc0.3: [patch] Add SIOCGIFHWADDR support for pfinet
Hello,
On Sun, Apr 10, 2005 at 10:11:20AM +0900, GOTO Masanori wrote:
> At Sat, 9 Apr 2005 13:53:38 +0200,
> Michael Banck wrote:
> > Any news on this? This touches only files in sysdeps/mach/hurd, and
> > we're happy to have this in 00list.hurd-i386.
>
> BTW, Did Hurd decided to use ioctl + SIOCGIFHWADDR (which is Linux
> specific) for getting MAC address? Or is it just workaround for
> dhclient? This kind of interface is different on each OSes.
As the Hurd uses the Linux networking stack currently, this does not
strike me as odd.
Perhaps Roland can weigh in his opinion on this. Roland, do you think
this patch is potentially acceptable, provided it gets cleaned up as
Marcus indicated in the link provided in the quoted text below?
> Even if this patch is applied, the rest part of Marco's patch is
> needed to work this ioctl correctly - it seems this dicussion is under
> going. Hurd guys, is this patch already accepted?
The Hurd part of the patch has not been accepted upstream, but it is
included in the Debian hurd package.
It has not been revised yet, due to Marco being short on time currently.
However, my impression was that these were rather superficial changes,
and the patch works fine with dhclient at least.
> > On Sun, Feb 13, 2005 at 09:19:18PM +0100, Michael Banck wrote:
> > > The following patch by Marco Gerards is the glibc part of SIOCGIFHWADDR
> > > support for pfinet on the Hurd. This is needed e.g. for dhclient to
> > > properly transmit the MAC-address to the server, so IP addresses can get
> > > handed out based on the hardware address. Otherwise, DHCP would be
> > > quite limited.
> > >
> > > The patch was submitted in
> > > http://lists.gnu.org/archive/html/bug-hurd/2004-08/msg00014.html
> > > and mostly acked by Marcus Brinkmann in
> > > http://lists.gnu.org/archive/html/bug-hurd/2005-02/msg00106.html
> > > requesting minor changes which are not applicable to the glibc part of
> > > the patch.
> > >
> > > Please apply.
> > >
> > >
> > > thanks,
> > >
> > > Michael
> >
> > > 2004-08-03 Marco Gerards <metgerards@student.han.nl>
> > >
> > > * sysdeps/mach/hurd/bits/ioctls.h (SIOCGIFHWADDR): New macro.
> > >
> > > Index: sysdeps/mach/hurd/bits/ioctls.h
> > > ===================================================================
> > > RCS file: /cvs/glibc/libc/sysdeps/mach/hurd/bits/ioctls.h,v
> > > retrieving revision 1.7
> > > diff -u -p -u -p -r1.7 ioctls.h
> > > --- sysdeps/mach/hurd/bits/ioctls.h 6 Jul 2001 04:55:58 -0000 1.7
> > > +++ sysdeps/mach/hurd/bits/ioctls.h 3 Aug 2004 13:55:34 -0000
> > > @@ -226,6 +226,7 @@ enum __ioctl_datum { IOC_8, IOC_16, IOC_
> > > #define SIOCSIFADDR _IOW('i', 12, struct ifreq) /* set ifnet address */
> > > #define OSIOCGIFADDR _IOWR('i',13, struct ifreq) /* get ifnet address */
> > > #define SIOCGIFADDR _IOWR('i',33, struct ifreq) /* get ifnet address */
> > > +#define SIOCGIFHWADDR _IOWR('i',39, struct ifreq) /* get hwaddress */
> > > #define SIOCSIFDSTADDR _IOW('i', 14, struct ifreq) /* set p-p address */
> > > #define OSIOCGIFDSTADDR _IOWR('i',15, struct ifreq) /* get p-p address */
> > > #define SIOCGIFDSTADDR _IOWR('i',34, struct ifreq) /* get p-p address */
cheers,
Michael
--
Michael Banck
Debian Developer
mbanck@debian.org
http://www.advogato.org/person/mbanck/diary.html
Reply to: