[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#256502: marked as done (debian/generate-asm.sh contains XSI:isms)



Your message dated Sat, 31 Jul 2004 10:47:08 -0400
with message-id <E1Bqv8e-0007wO-00@newraff.debian.org>
and subject line Bug#256502: fixed in linux-kernel-headers 2.5.999-test7-bk-17
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at maintonly) by bugs.debian.org; 27 Jun 2004 14:44:28 +0000
>From tao@acc.umu.se Sun Jun 27 07:44:28 2004
Return-path: <tao@acc.umu.se>
Received: from khan.acc.umu.se [130.239.18.139] (postfix)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BeatQ-0006FW-00; Sun, 27 Jun 2004 07:44:28 -0700
Received: from localhost (localhost [127.0.0.1])
	by amavisd-new (Postfix) with ESMTP id DCB2AD29C
	for <maintonly@bugs.debian.org>; Sun, 27 Jun 2004 16:44:26 +0200 (MEST)
Received: by khan.acc.umu.se (Postfix, from userid 23136)
	id 08229D287; Sun, 27 Jun 2004 16:44:25 +0200 (MEST)
Date: Sun, 27 Jun 2004 16:44:24 +0200
From: David Weinehall <tao@debian.org>
To: "Debian Bug Tracking System, Maintonly" <maintonly@bugs.debian.org>
Subject: debian/generate-asm.sh contains XSI:isms
Message-ID: <20040627144424.GN7888@khan.acc.umu.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.1i
X-Accept-Language: Swedish, English
X-GPG-Fingerprint: 7ACE 0FB0 7A74 F994 9B36  E1D1 D14E 8526 DC47 CA16
X-GPG-Key: http://www.acc.umu.se/~tao/files/pubkey_dc47ca16.gpg.asc
X-Virus-Scanned: by amavisd-new at acc.umu.se
Delivered-To: maintonly@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_01,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Package: linux-kernel-headers
Version: 2.5.999-test7-bk-16
Severity: minor
Tags: patch

debian/generate-asm.sh contains use of the XSI:isms `-a' and `-o' in
tests.  This is technically a violation of policy.  The included patch
fixes this.

Rationale:

policy 10.4
http://www.opengroup.org/onlinepubs/009695399/utilities/test.html


Regards: David Weinehall

diff -ur linux-kernel-headers-2.5.999-test7-bk-old/debian/generate-asm.sh linux-kernel-headers-2.5.999-test7-bk/debian/generate-asm.sh
--- linux-kernel-headers-2.5.999-test7-bk-old/debian/generate-asm.sh	2004-06-27 17:19:15.000000000 +0300
+++ linux-kernel-headers-2.5.999-test7-bk/debian/generate-asm.sh	2004-06-27 17:21:20.000000000 +0300
@@ -12,7 +12,7 @@
 	cd /usr/include
 fi
 
-if [ ! -d asm-sparc -o ! -d asm-sparc64 ] ; then
+if [ ! -d asm-sparc ] || [ ! -d asm-sparc64 ] ; then
 	echo E: asm-sparc and asm-sparc64 must exist, or you will have problems
 	exit 1
 fi
@@ -34,7 +34,7 @@
 EOF
 
 	# common for sparc and sparc64
-	if [ -f asm-sparc/$h -a -f asm-sparc64/$h ]; then
+	if [ -f asm-sparc/$h ] && [ -f asm-sparc64/$h ]; then
 		cat >> asm/$h <<EOF
 #ifdef __arch64__
 #include <asm-sparc64/$h>

---------------------------------------
Received: (at 256502-close) by bugs.debian.org; 31 Jul 2004 14:49:53 +0000
>From katie@ftp-master.debian.org Sat Jul 31 07:49:53 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BqvBI-0001QM-00; Sat, 31 Jul 2004 07:49:53 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1Bqv8e-0007wO-00; Sat, 31 Jul 2004 10:47:08 -0400
From: GOTO Masanori <gotom@debian.org>
To: 256502-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#256502: fixed in linux-kernel-headers 2.5.999-test7-bk-17
Message-Id: <E1Bqv8e-0007wO-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sat, 31 Jul 2004 10:47:08 -0400
Delivered-To: 256502-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Score: 3

Source: linux-kernel-headers
Source-Version: 2.5.999-test7-bk-17

We believe that the bug you reported is fixed in the latest version of
linux-kernel-headers, which is due to be installed in the Debian FTP archive:

linux-kernel-headers_2.5.999-test7-bk-17.diff.gz
  to pool/main/l/linux-kernel-headers/linux-kernel-headers_2.5.999-test7-bk-17.diff.gz
linux-kernel-headers_2.5.999-test7-bk-17.dsc
  to pool/main/l/linux-kernel-headers/linux-kernel-headers_2.5.999-test7-bk-17.dsc
linux-kernel-headers_2.5.999-test7-bk-17_i386.deb
  to pool/main/l/linux-kernel-headers/linux-kernel-headers_2.5.999-test7-bk-17_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 256502@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
GOTO Masanori <gotom@debian.org> (supplier of updated linux-kernel-headers package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun,  6 Jun 2004 05:35:11 +0900
Source: linux-kernel-headers
Binary: linux-kernel-headers
Architecture: source i386
Version: 2.5.999-test7-bk-17
Distribution: unstable
Urgency: low
Maintainer: GOTO Masanori <gotom@debian.org>
Changed-By: GOTO Masanori <gotom@debian.org>
Description: 
 linux-kernel-headers - Linux Kernel Headers for development
Closes: 252651 252720 256502 259766
Changes: 
 linux-kernel-headers (2.5.999-test7-bk-17) unstable; urgency=low
 .
   * GOTO Masanori <gotom@debian.org>
 .
     - Don't use the XSI:isms `-a' and `-o' in tests for
       debian/generate-asm.sh from David Weinehall <tao@debian.org>.
       (Closes: #256502)
     - Install i386 kernel headers into /usr/include/i386-linux on x86-64
       from Andreas Jochens <aj@andaco.de>.  (Closes: #252720)
     - Fix 64bit conversion makes weird behavior on s390 from
       Bastian Blank <waldi@debian.org>.  (Closes: #259766)
       - s390-asm-byteorder.patch
     - Fix <asm/types.h> -ansi vs long long.  (Closes: #252651)
       - asm-types-long-long.patch
     - Revert x86-64 <asm/types.h> modification in x86-64-long-long.patch
       because asm-types-long-long.patch fixes more appropriate method.
Files: 
 f6d1dd1fb48e99c4b5eb94a756befb6b 856 devel standard linux-kernel-headers_2.5.999-test7-bk-17.dsc
 ba578f0c6a1bc8a852e040ff8206fcaf 56582 devel standard linux-kernel-headers_2.5.999-test7-bk-17.diff.gz
 1fcca61cd0f5df09afddcc425f46bd64 1377022 devel standard linux-kernel-headers_2.5.999-test7-bk-17_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBC605qIqasIZIJsMRAnuOAJ9S2V64NA/n5jSGA1mg7FKG39sQtwCfW9Nq
mbXbtUp3v0BqzSmCmkOekaw=
=ll78
-----END PGP SIGNATURE-----



Reply to: