Bug#216921: The Problem exists in other programms too

[GOTO Masanori <gotom@debian.or.jp>]

At Mon, 03 Nov 2003 16:05:06 +0100,
nix.wie.weg@gmx.de wrote:
> I think it's not the right way, to break now a lot of programs without 
> warning! I have the same effects in "kino":
> 
> <snip>
> In file included from /usr/include/linux/device.h:15,
>                  from /usr/include/linux/videodev.h:6,
>                  from v4l.h:40,
>                  from page_bttv.h:29,
>                  from kino_common.cc:50:
> /usr/include/linux/ioport.h:91: error: parse error before `new'
> /usr/include/linux/ioport.h:92: error: parse error before `new'
> /usr/include/linux/ioport.h:93: error: parse error before `new'
> /usr/include/linux/ioport.h:94: error: parse error before `new'
> /usr/include/linux/ioport.h:99: error: `allocate_resource' declared as 
> function
>    returning a function
> <snip>
> 
> It worked until now without any problems, but after the last "unstable" 
> libc6-dev update it does not work anymore. If such a change has to 
> happen, then not without throwing warning messages on each compilation 
> of such userspace applications, for at least one year and change it 
> afterwards.
> 
> SO IT IS A BUG! The tenor: "Oh sorry, it was never meant to work that 
> way, so we made sure, that it will not work" is the microsoft way of 
> life and it is the false one. It worked until now without any problems, 
> it does not work anymore, so we have introduced a bug!

I don't know your bug, but original report is fixed with patching
/usr/include/linux/fb.h.

The problem is (1) workqueue.h should include in __KERNEL__, (2)
struct fb_pixmap should be in __KERNEL__ because it includes
spinlock_t.  If some applications use fb_pixmap, please let me know.
In that case, the design of fb header structure is broken, and need
more fix.

In addition, I think everytime we shouldn't say copying constants into
userland is good.

Regards,
-- gotom