[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1010364: marked as done (libffi overrides DEB_BUILD_OPTIONS=nocheck)

Your message dated Thu, 22 Sep 2022 17:09:58 +0000
with message-id <E1obPi2-00DprM-0r@fasolo.debian.org>
and subject line Bug#1010364: fixed in libffi 3.4.3-2
has caused the Debian Bug report #1010364,
regarding libffi overrides DEB_BUILD_OPTIONS=nocheck
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1010364: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010364
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: libffi
Version: 3.4.2-4
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

Hi Matthias,

I see that you made libffi override DEB_BUILD_OPTIONS=nocheck in certain
situations. I think your override is too broad as it also covers cross
builds. I'm attaching a patch that narrows down your override to native
builds only and I think it still covers the intended use (as you
explained in the commend). What do you think?

Helmut

diff --minimal -Nru libffi-3.4.2/debian/changelog libffi-3.4.2/debian/changelog
--- libffi-3.4.2/debian/changelog	2022-01-17 11:37:08.000000000 +0100
+++ libffi-3.4.2/debian/changelog	2022-04-29 17:59:05.000000000 +0200
@@ -1,3 +1,10 @@
+libffi (3.4.2-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Don't override DEB_BUILD_OPTIONS=nocheck for cross builds. Closes: #-1.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Fri, 29 Apr 2022 17:59:05 +0200
+
 libffi (3.4.2-4) unstable; urgency=medium
 
   * Configure --without-gcc-arch. Closes: #995223.
diff --minimal -Nru libffi-3.4.2/debian/rules libffi-3.4.2/debian/rules
--- libffi-3.4.2/debian/rules	2022-01-17 11:37:06.000000000 +0100
+++ libffi-3.4.2/debian/rules	2022-04-29 17:59:03.000000000 +0200
@@ -26,7 +26,7 @@
   with_check = yes
 else
   # override buildd admins to run the testsuite anyway ...
-  ifneq (,$(filter $(DEB_HOST_ARCH), m68k powerpcspe sh4))
+  ifeq ($(DEB_BUILD_ARCH),$(filter $(DEB_HOST_ARCH), m68k powerpcspe sh4))
     with_check = yes
   endif
 endif

--- End Message ---
--- Begin Message --- 
Source: libffi
Source-Version: 3.4.3-2
Done: Matthias Klose <doko@debian.org>

We believe that the bug you reported is fixed in the latest version of
libffi, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1010364@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Matthias Klose <doko@debian.org> (supplier of updated libffi package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 22 Sep 2022 15:29:34 +0200
Source: libffi
Architecture: source
Version: 3.4.3-2
Distribution: unstable
Urgency: medium
Maintainer: Debian GCC Maintainers <debian-gcc@lists.debian.org>
Changed-By: Matthias Klose <doko@debian.org>
Closes: 1010364 1012632 1012697 1020488 1020490
Changes:
 libffi (3.4.3-2) unstable; urgency=medium
 .
   * Re-apply the 3.4.3 -2/-3/-4 changes. Closes: #1020488, #1020490.
   * Update copyright file (Bastian Germann). Closes: #1012632.
   * Update watch file (Bastian Germann). Closes: #1012697.
   * Don't override DEB_BUILD_OPTIONS=nocheck for cross builds (Helmut Grohne).
     Closes: #1010364.
Checksums-Sha1:
 15a1a303976a5d88cc2811de75db47d9b433ee5a 1951 libffi_3.4.3-2.dsc
 4d63ba26731b9dc50e272cda9257a5855ac7f369 10156 libffi_3.4.3-2.debian.tar.xz
 3024c9c64692f4f564d5f8557875d0e5aa193b06 6555 libffi_3.4.3-2_source.buildinfo
Checksums-Sha256:
 ed1365bd72e2d5de2a56ad24d8d5499dde5018956c3f44c1737d5901f2e3cbdc 1951 libffi_3.4.3-2.dsc
 b8b452decf3f6b327cf7c3a0586e01b4168037d513d9949c9d5907e8115b16c0 10156 libffi_3.4.3-2.debian.tar.xz
 acb18ae502597872159b2815569aa94a4874dcd24287e9e2d450eb22483e243d 6555 libffi_3.4.3-2_source.buildinfo
Files:
 b5e6bd5750d6d675e1e2ca1f2a7c0565 1951 libs optional libffi_3.4.3-2.dsc
 333a3c20f73fdd2b97a91f6bda1e027c 10156 libs optional libffi_3.4.3-2.debian.tar.xz
 f67bdbc7ba6d47175b58168412aa91ee 6555 libs optional libffi_3.4.3-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEE1WVxuIqLuvFAv2PWvX6qYHePpvUFAmMsZMIQHGRva29AZGVi
aWFuLm9yZwAKCRC9fqpgd4+m9YpREACemd0nFkkoEsf3XjOlzdLCocG4NVnhojE/
05zM9Ei3qrixpIPLupXlppiW9NqIrpN0sNHXe2D7bsYI5Nerpj0shRamsi9o1+sV
oQ5SikJthNNdBnc9IZUs118ewIteNyMfw+3i3COTAnw4aakzqnMn468Lq13gY652
n7jvRSHiIF1kT8Qj6AmxE57CgszVpxY7cG96rNqeb0SmNGJSQwUbplbJU4e+5pH7
Ie9JurcM9tRyiLeQQeV/uG5iAd6WRXA/NOGloIPbw175uxyAPs+vLPB+2nUaDUVA
hr/zUV0n9KEmOVYJdSK+fPldCkdTGXVXM0wqz/sIBQx3Ct052j1KhXKder6iYW2i
nCXQNTbvBk4brIkGm0gjdXU7G6a94xQxkpJFfDVQcrWiwFjIqnpkXcLCh99YF5Zv
K3aRjgGzeyyxbU7IfdycPn4R9xJXFwfNUIJFZ/ROdWU4PtFtnwxgzkn6W4j3YMHL
Sa7y7u9x/Q/AKRuzrO8mCbz3Z1sNkeMShRDXqHpqHIdjtN/jCP2/CoQMWxLIGWIS
WG2Hu81q0Ae7UxWE8n7Y7clIjhXnRbaId65uGkDHhcnnfMfIz7l3F3fC/0jIYReq
1GiES/j6Y3UYyof8gGo+fh5sJVYVtl6q+fqZPMCo0fCPlfFQCDz1MKcFSho0pNDM
dCOervI2Rw==
=EzBn
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: