[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#266345: marked as done ([DPKG-BUILDPACKAGE] -S doesn't check for build-depends)



Your message dated Fri, 18 Mar 2005 13:36:42 +0000
with message-id <1111153002.9006.102.camel@descent.netsplit.com>
and subject line Bug#266345: "dpkg-buildpackage -S" doesn't check for build-dependencies
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 17 Aug 2004 16:50:53 +0000
>From rmh@khazad.dyndns.org Tue Aug 17 09:50:53 2004
Return-path: <rmh@khazad.dyndns.org>
Received: from 86.red-80-24-13.pooles.rima-tde.net (khazad.dyndns.org) [80.24.13.86] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Bx7Ag-0000GR-00; Tue, 17 Aug 2004 09:50:52 -0700
Received: from aragorn ([192.168.0.1] helo=khazad.dyndns.org)
	by khazad.dyndns.org with esmtp (Exim 3.36 #1 (Debian))
	id 1Bx7IT-0004mN-00; Tue, 17 Aug 2004 18:58:53 +0200
Received: from rmh by khazad.dyndns.org with local (Exim 4.34)
	id 1Bx79m-000FSa-Ny; Tue, 17 Aug 2004 18:49:54 +0200
Content-Type: multipart/mixed; boundary="===============0034486306=="
MIME-Version: 1.0
From: Robert Millan <rmh@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: "dpkg-buildpackage -S" doesn't check for build-dependencies
X-Mailer: reportbug 2.64
Date: Tue, 17 Aug 2004 18:49:54 +0200
Message-Id: <E1Bx79m-000FSa-Ny@khazad.dyndns.org>
Sender: <rmh@khazad.dyndns.org>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

This is a multi-part MIME message sent by reportbug.

--===============0034486306==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: dpkg
Version: 1.10.23+kbsd
Severity: important
Tags: patch

Policy 7.6 reads:

  "The Build-Depends and Build-Conflicts fields must be satisfied when any of
  the following targets is invoked: [...], clean, [...]."

"dpkg-buildpackage -S" runs the clean target, therefore should check for
Build-Depends.  The attached patch fixes the problem.

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: kfreebsd-i386 (i386)
Kernel: GNU/kFreeBSD 5.2.1-5
Locale: LANG=C, LC_CTYPE=C (ignored: LC_ALL set to C)

Versions of packages dpkg depends on:
ii  dselect                     1.10.23+kbsd a user tool to manage Debian packa
ii  libc0.1                     2.3-1+kbsd.3 GNU C Library: Shared libraries an

-- no debconf information

--===============0034486306==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="dpkg_1.10.23.diff"

--- dpkg-1.10.23/scripts/dpkg-buildpackage.sh~	2004-07-19 20:56:53.000000000 +0200
+++ dpkg-1.10.23/scripts/dpkg-buildpackage.sh	2004-08-17 18:42:59.000000000 +0200
@@ -99,7 +99,7 @@
 			{ echo >&2 "$progname: cannot combine $1 and -S" ; exit 2 ; } ;;
 	-B)	binaryonly=-B; checkbuilddep_args=-B; binarytarget=binary-arch; [ "$sourceonly" ] && \
 			{ echo >&2 "$progname: cannot combine $1 and -S" ; exit 2 ; } ;;
-	-S)	sourceonly=-S; checkbuilddep=false; [ "$binaryonly" ] && \
+	-S)	sourceonly=-S; checkbuilddep_args=-B; [ "$binaryonly" ] && \
 			{ echo >&2 "$progname: cannot combine $binaryonly and $1" ; exit 2 ; } ;;
 	-v*)	since="$value" ;;
 	-m*)	maint="$value" ;;

--===============0034486306==--

---------------------------------------
Received: (at 266345-done) by bugs.debian.org; 18 Mar 2005 13:36:46 +0000
>From scott@netsplit.com Fri Mar 18 05:36:45 2005
Return-path: <scott@netsplit.com>
Received: from populous.netsplit.com (mailgate.netsplit.com) [62.49.129.34] (qmailr)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DCHef-0006bX-00; Fri, 18 Mar 2005 05:36:45 -0800
Received: (qmail 3887 invoked from network); 18 Mar 2005 13:36:42 -0000
Received: from unknown (HELO descent.netsplit.com) (scott@62.49.129.40)
  by populous.netsplit.com with SMTP; 18 Mar 2005 13:36:42 -0000
Subject: Re: Bug#266345: "dpkg-buildpackage -S" doesn't check for
	build-dependencies
From: Scott James Remnant <scott@netsplit.com>
To: 266345-done@bugs.debian.org, Robert Millan <rmh@debian.org>
In-Reply-To: <E1Bx79m-000FSa-Ny@khazad.dyndns.org>
References: <E1Bx79m-000FSa-Ny@khazad.dyndns.org>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-Gq5kIXMt5HOOipKjcFTt"
Date: Fri, 18 Mar 2005 13:36:42 +0000
Message-Id: <1111153002.9006.102.camel@descent.netsplit.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.0 
Delivered-To: 266345-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 


--=-Gq5kIXMt5HOOipKjcFTt
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 2004-08-17 at 18:49 +0200, Robert Millan wrote:

> Policy 7.6 reads:
>=20
>   "The Build-Depends and Build-Conflicts fields must be satisfied when an=
y of
>   the following targets is invoked: [...], clean, [...]."
>=20
> "dpkg-buildpackage -S" runs the clean target, therefore should check for
> Build-Depends.  The attached patch fixes the problem.
>=20
I agree with Junichi here.

Policy is aimed at the maintainers of packages and instructs them on the
proper creation of their rules and control file.  The intent of 7.6 is
to ensure that packages declare in Build-Depends any packages that
should to be installed in order to execute the rules.

dpkg-buildpackage isn't held by this part of policy, and isn't a lint
program.  dpkg-checkbuilddeps behaves correctly, and that's the lint
part of dpkg.

I'm going to close this as an invalid wish.

Scott
--=20
Have you ever, ever felt like this?
Had strange things happen?  Are you going round the twist?

--=-Gq5kIXMt5HOOipKjcFTt
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQBCOtlpIexP3IStZ2wRAvByAJ9pDR2pFBS+mI/2hGtQyxl3+WJ4qACfUBsh
64sMtCs1D1ggCkQcHDDxsF0=
=1QBu
-----END PGP SIGNATURE-----

--=-Gq5kIXMt5HOOipKjcFTt--



Reply to: