Re: Tiny patch to dpkg-1.0.11 for m68k

[Ian Jackson <ian@chiark.chu.cam.ac.uk>]

Frank Neumann writes ("Tiny patch to dpkg-1.0.11 for m68k"):
> when trying to compile dpkg-1.0.11 for our upcoming Debian/m68k,
> I had to make one tiny change that you have probably also received
> before from Juergen Menden:
> 
> [moved to end - iwj ]
> 
> Without this patch, those 3 functions are not visible in other modules,
> and are not found when compiling. I hope you'll integrate this patch into
> your version, too.
> 
> If I'm missing a point here, please tell me.

This is a compiler bug.  These functions ought to be static, and they
aren't used anywhere else.

We had the same problem with early Debian i386 ELF compilers.

Ian.

> --- cut here ---
> *** dpkg-1.0.11/dselect/main.cc.orig	Tue Jan 23 19:13:03 MET 1996
> --- dpkg-1.0.11/dselect/main.cc	Tue Jan 23 19:13:19 MET 1996
> ***************
> *** 96,109 ****
>          stderr)) werr("stderr");
>   }
>   
> ! static void helponly(const struct cmdinfo*, const char*) {
>     usage(); exit(0);
>   }
> ! static void versiononly(const struct cmdinfo*, const char*) {
>     printversion(); exit(0);
>   }
>   
> ! static void setdebug(const struct cmdinfo*, const char *v) {
>     debug= fopen(v,"a");
>     if (!debug) ohshite("couldn't open debug file `%.255s'\n",v);
>     setvbuf(debug,0,_IONBF,0);
> --- 96,109 ----
>          stderr)) werr("stderr");
>   }
>   
> ! void helponly(const struct cmdinfo*, const char*) {
>     usage(); exit(0);
>   }
> ! void versiononly(const struct cmdinfo*, const char*) {
>     printversion(); exit(0);
>   }
>   
> ! void setdebug(const struct cmdinfo*, const char *v) {
>     debug= fopen(v,"a");
>     if (!debug) ohshite("couldn't open debug file `%.255s'\n",v);
>     setvbuf(debug,0,_IONBF,0);
> --- cut here ---