[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: wishlist for dpkg



tag #### + wontfix
thanks

On 18 May 2001, Tollef Fog Heen wrote:

> * Adam Heath
>
> | On Fri, 18 May 2001, Ulf Jaenicke-Roessler wrote:
> |
> | >  Hmmm, my thought was, that data.tar.gz shouldn't be unpacked at all, if
> | >  the (additional) checksum does not match. But I don't know any internals
> | >  of dpkg, so this might quite well be wrong.
> |
> | This requires scanning the entire data.tar.gz, seeing that it is valid, then
> | processing it all again, to extract it.
>
> How about first extracting it, seeing that it went ok and then
> untarring?
>
> Not that I know how this is implemented internally in dpkg, but if
> feasible, this would be a slowdown, but not so bad as a full scan.
>
> Or go the way of having an md5sum of data.tar.gz in the ar.

It'll still be half speed.

The md5sum would be of the final, compressed form, not the uncompressed
data.tar.  When checking the md5sum, the data.tar.gz would have to be read
from .deb, and then when extracting it, the data.tar.gz would have to be read
a 2nd time.

As Wichert as said, doing this would be a hack around the real problem.  That
dpkg doesn't clean up when an error occurs during extraction(at least not in
this case).

ps: This message was not sent to control@bugs, but the first paragraph is how
I feel about this thread.



Reply to: