[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#733452: Minimal code for systemd protocol



Ian Jackson wrote:
> Nikolaus Rath writes ("Bug#733452: Minimal code for systemd protocol"):
> > It's already been mentioned elsewhere, but I think it should be
> > included in this bug for reference. The minimum code to support
> > systemd style readyness notification is (from
> > https://plus.google.com/+LennartPoetteringTheOneAndOnly/posts/37AWJLE3XcJ):
> 
> This code snippet does not do what sd_notify(3) says is required, but
> perhaps the documentation is wrong.

What part of sd_notify(3) are you referring to?  The full implementation
of sd_notify in
http://cgit.freedesktop.org/systemd/systemd/plain/src/libsystemd-daemon/sd-daemon.c
does not contain any semantic additions to the algorithm.

If you're talking about SCM_CREDENTIALS, then as has already been
mentioned elsewhere, that's not the concern of the daemon process.
Perhaps sd_notify(3) could, for clarity, explicitly say "The process
receiving the datagram (e.g. systemd) may wish to use SCM_CREDENTIALS to
obtain the process credentials of the sending daemon."

- Josh Triplett


Reply to: