Re: Temporarily revert r5584 and r5585 to bring back in the next upload

[Steven Chamberlain <steven@pyro.eu.org>]

Hi,

I didn't receive this mail until today, sorry:

Petr Salinger wrote:
> --- trunk/freebsd-utils/debian/control	2014-10-04 21:44:05 UTC (rev 5597)
> +++ trunk/freebsd-utils/debian/control	2014-10-04 21:47:18 UTC (rev 5598)
> @@ -8,7 +8,6 @@
>  Build-Depends: debhelper (>= 7), po-debconf, sharutils,
>   flex | flex-old,
>   freebsd-buildutils (>= 9.0-8~),
> - freebsd-mk (>= 10.0-5),
>   freebsd-glue (>= 0.2.17~),
>   kfreebsd-kernel-headers (>= 10.1~2),
>  # for kdump
> 
> This has been added due to real need of RC-1 snapshot.

freebsd-utils in SVN trunk did not point at the new RC1 snapshot yet,
it still had version ~svn271687 and debian/rules still referred to
upstream SVN stable/10/

The changes did not have changelog entries.  Did you forget to commit
some parts from your work tree?

> There is corresponding change, backported into 10.0:
> 
> freebsd-buildutils (10.0-5) UNRELEASED; urgency=low
> 
>   * Backport mk_hyperv, needed by 10.1 RC

While here - we are also missing an MK_TESTS (off by default) which I
worked around in freebsd-utils for now.

> --- trunk/freebsd-utils/debian/rules	2014-10-04 21:44:05 UTC (rev 5597)
> +++ trunk/freebsd-utils/debian/rules	2014-10-04 21:47:18 UTC (rev 5598)
> @@ -231,8 +231,7 @@
>  #	dh_installinfo
>  	dh_installman
>  	dh_link
> -	dh_fixperms -X/usr/bin/netstat
> -	dh_strip -X/usr/bin/netstat
> +	dh_strip
>  	dh_compress
>  	dh_fixperms -X/usr/bin/netstat
>  #	dh_perl
> 
> 
> The problem seems that dh_strip internally copies the file,
> which might have suid/sgid bit (in case of netstat sgid)

Does netstat need to be sgid?  It seems to work as a normal user, what
extra functionality does that provide?

> And there are other suid/sgid binaries,
> which we do not ship suid/sgid, that is a reson, why dh_fixperms is
> called also before dh_strip, to strip them without problem.

I didn't know this change affected other binaries.  There really should
be an entry in changelog mentioning binaries that became setuid/setgid.

> I prefer to ship freebsd-utils into unstable using
> the same SVN snapshot (272463 or 272500) as for other components,
> not only BETA (272167).

Sorry, that already happened before I saw your mail.  I expected r272500
freebsd-utils would need more testing first anyway by us, including the
udebs built from it, then can be updated in another upload soon.

Regards,
-- 
Steven Chamberlain
steven@pyro.eu.org