On Fri, 2017-11-10 at 12:32 -0500, Lennart Sorensen wrote: > On Fri, Nov 10, 2017 at 04:19:14PM +0000, Ben Hutchings wrote: > > This is true, but I don't think it's a good reason not to implement a > > mostly-reliable heuristic. > > > > If there are multiple disks, there are usually going to be just 2 of > > them, one of which contains the installer. In any installer build > > other than netboot, it will look for its own disk in order to load > > udebs. Once it has done that, it can determine that the other disk is > > the one to install on. That's a pretty good heuristic. > > I think more than one disk in the machine isn't that unusual. The context of this bug is that Michael wants to partition a single disk - not set up a RAID. I think it *is* unusual that Debian would be installed on a single disk of a system that contains multiple internal disks. If someone really wants to pre-seed partman in that case then they would have to specify the device name just as they do now (presumably using /dev/disk/by-path/...). > > Aside from that, we can also make a guess based on the bus type: > > > > - ATA: probably internal > > eSATA is not that unusual. > > > - NVMe: probably internal > > - USB: probably external > > - MMC/SD: ambiguous (eMMC must be internal, and Linux has a notion of > > 'non-removable' slots, but I don't think userland has this info) > > > > If we could get more information about MMC/SD slots then we should be > > able to implement an heuristic that would work for >99% of cases. > > You can certainly try to make a good guess, but it certainly still needs > to be confirmed. That seems to defeat the point of pre-seeding. Ben. -- Ben Hutchings Who are all these weirdos? - David Bowie, reading IRC for the first time
Attachment:
signature.asc
Description: This is a digitally signed message part