[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#726298: debian-installer: graphical install as KVM guest crashes when switching to text console



Control: tag -1 + wontfix moreinfo - patch

14.10.2013 14:45, Thiemo Nagel wrote:
> severity 726298 wishlist
> retitle 726298 Give guidance to console-switching installer users
> reassign 726298 busybox
> tags 726298 + patch
> thanks
> 
> It's all my fault. I just realized that X is fine, I just didn't
> expect it to live on console #5. Maybe the attached patch could help
> prevent others falling into the same trap?

First of all, somehow I haven't noticed this bugreport until now.

Here's your patch:

 From d2e289c95d454ec752af14b18b417ce30fca741d Mon Sep 17 00:00:00 2001
 From: Thiemo Nagel <thiemo.nagel@gmail.com>
 Date: Mon, 14 Oct 2013 12:34:41 +0200
 Subject: [PATCH] Add help message to inactive consoles

 --- a/init/init.c
 +++ b/init/init.c
 @@ -485,7 +485,10 @@ static pid_t run(const struct init_action *a)
  #ifdef CUSTOMIZED_BANNER
  #include CUSTOMIZED_BANNER
  #endif
 -			"\nPlease press Enter to activate this console. ";
 +			"\nPlease press Enter to activate this console. "
 +			"(Hit Ctrl-Alt-F5 to return to the graphical "
 +			"installer or Ctrl-Alt-F1 for the text-mode "
 +			"installer, respectively.) ";


This is completely wrong.  There's no reason X installer should be running
on tty5 or text-mode installer on tty1.  This patch breaks regular use
of busybox, because outside of the d-i environment, there's no reason to
expect the installer to be running at all.

As far as I remember, things are actually documented in the installation
manual, isn't that not enough?

Thanks,

/mjt


Reply to: