Bug#724931: Patch works great
On Mon, 30 Sep 2013 21:54:15 +0200
Andreas Cadhalpun <andreas.cadhalpun@googlemail.com> wrote:
> I have applied your patch to the debian-testing-amd64-netinst.iso and
> also included the loop.ko. This increased the size from 230.7 MB to
> 232.3 MB, i.e. by 0.7 %.
This must be because of differences in compression, or something else in
the build method. The combined size of the patch code and the loop.ko
module is about 37KB (uncompressed), not 1.6MB. In other words, it's
completely negligible.
> The patch itself is very straightforward, short, and most importantly
> works very well. Thank you!
I'm glad you found it satisfactory.
> The only missing thing is 'LOOPFS=' for kfreebsd and hurd.
Yes, I pointed that out in my original post to the mailing list. I will
forward that to the bug report, for completeness.
> Therefore I would suggest to forget about the findiso option and
> simply apply this patch to all the Debian isos.
I certainly have no objection to that, although I think it would be a
good thing if the install ISOs and the live ISOs both used the same
loopmount mechanism.
> (For comptability one could rename 'loopmount=' into 'findiso='.)
It might be better not to do that, in case there are any slight
differences in function, which is to say, "incompatibilities".
I think that "loopmount" is more descriptive of what is happening than
"findiso", anyway.
-- Ian Bruce
Reply to: